Skip to content

Commit 113b070

Browse files
committed
fix(swan_r5): 3v3 was enabled but then immediately reset. Moved initialization to reset_board which happens after reset_all_pins.
1 parent edfabb6 commit 113b070

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

ports/stm/boards/swan_r5/board.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ void board_init(void) {
5959
// Without this, USB does not function.
6060
HAL_InitTick((1UL << __NVIC_PRIO_BITS) - 1UL);
6161

62-
initialize_discharge_pin();
63-
6462
__HAL_RCC_GPIOE_CLK_ENABLE();
6563
GPIO_InitTypeDef GPIO_InitStruct;
6664
GPIO_InitStruct.Mode = GPIO_MODE_OUTPUT_PP;
@@ -78,6 +76,7 @@ bool board_requests_safe_mode(void) {
7876
}
7977

8078
void reset_board(void) {
79+
initialize_discharge_pin();
8180
}
8281

8382
void board_deinit(void) {

ports/stm/boards/swan_r5/mpconfigboard.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,3 +64,6 @@
6464

6565
#define DEFAULT_UART_BUS_RX (&pin_PA10)
6666
#define DEFAULT_UART_BUS_TX (&pin_PA09)
67+
68+
#define SWAN_R5_DISCHARGE_3V3 (&pin_PE06)
69+
#define SWAN_R5_ENABLE_3V3 (&pin_PE04)

ports/stm/boards/swan_r5/pins.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ STATIC const mp_rom_map_elem_t board_module_globals_table[] = {
8686

8787
{ MP_ROM_QSTR(MP_QSTR_ext), MP_ROM_PTR(&carrier_type) },
8888

89-
{ MP_ROM_QSTR(MP_QSTR_ENABLE_3V3), MP_ROM_PTR(&pin_PE04) },
90-
{ MP_ROM_QSTR(MP_QSTR_DISCHARGE_3V3), MP_ROM_PTR(&pin_PE06) },
89+
{ MP_ROM_QSTR(MP_QSTR_ENABLE_3V3), MP_ROM_PTR(SWAN_R5_ENABLE_3V3) },
90+
{ MP_ROM_QSTR(MP_QSTR_DISCHARGE_3V3), MP_ROM_PTR(SWAN_R5_DISCHARGE_3V3) },
9191
{ MP_ROM_QSTR(MP_QSTR_DISABLE_DISCHARGING), MP_ROM_TRUE },
9292
{ MP_ROM_QSTR(MP_QSTR_ENABLE_DISCHARGING), MP_ROM_FALSE },
9393

0 commit comments

Comments
 (0)