Convert default float values from null checks to MP_ROM_INT.

Author: relic-se

shared-bindings/audiofilters/Distortion.c

@@ -113,11 +113,11 @@ static audiofilters_distortion_mode validate_distortion_mode(mp_obj_t obj, qstr
 static mp_obj_t audiofilters_distortion_make_new(const mp_obj_type_t *type, size_t n_args, size_t n_kw, const mp_obj_t *all_args) {
     enum { ARG_drive, ARG_pre_gain, ARG_post_gain, ARG_mode, ARG_mix, ARG_buffer_size, ARG_sample_rate, ARG_bits_per_sample, ARG_samples_signed, ARG_channel_count, };
     static const mp_arg_t allowed_args[] = {
-        { MP_QSTR_drive, MP_ARG_OBJ | MP_ARG_KW_ONLY,  {.u_obj = MP_OBJ_NULL} },
-        { MP_QSTR_pre_gain, MP_ARG_OBJ | MP_ARG_KW_ONLY,  {.u_obj = MP_OBJ_NULL} },
-        { MP_QSTR_post_gain, MP_ARG_OBJ | MP_ARG_KW_ONLY,  {.u_obj = MP_OBJ_NULL} },
+        { MP_QSTR_drive, MP_ARG_OBJ | MP_ARG_KW_ONLY,  {.u_obj = MP_ROM_INT(0)} },
+        { MP_QSTR_pre_gain, MP_ARG_OBJ | MP_ARG_KW_ONLY,  {.u_obj = MP_ROM_INT(0)} },
+        { MP_QSTR_post_gain, MP_ARG_OBJ | MP_ARG_KW_ONLY,  {.u_obj = MP_ROM_INT(0)} },
         { MP_QSTR_mode, MP_ARG_OBJ | MP_ARG_KW_ONLY,  {.u_obj = MP_OBJ_NULL} },
-        { MP_QSTR_mix, MP_ARG_OBJ | MP_ARG_KW_ONLY,  {.u_obj = MP_OBJ_NULL} },
+        { MP_QSTR_mix, MP_ARG_OBJ | MP_ARG_KW_ONLY,  {.u_obj = MP_ROM_INT(1)} },
         { MP_QSTR_buffer_size, MP_ARG_INT | MP_ARG_KW_ONLY, {.u_int = 512} },
         { MP_QSTR_sample_rate, MP_ARG_INT | MP_ARG_KW_ONLY, {.u_int = 8000} },
         { MP_QSTR_bits_per_sample, MP_ARG_INT | MP_ARG_KW_ONLY, {.u_int = 16} },

shared-module/audiofilters/Distortion.c

@@ -62,31 +62,12 @@ void common_hal_audiofilters_distortion_construct(audiofilters_distortion_obj_t
 
     // The below section sets up the effect's starting values.
 
-    // If we did not receive a BlockInput we need to create a default float value
-    if (drive == MP_OBJ_NULL) {
-        drive = mp_obj_new_float(0.0);
-    }
     synthio_block_assign_slot(drive, &self->drive, MP_QSTR_drive);
-
-    // If we did not receive a BlockInput we need to create a default float value
-    if (pre_gain == MP_OBJ_NULL) {
-        pre_gain = mp_obj_new_float(0.0);
-    }
     synthio_block_assign_slot(pre_gain, &self->pre_gain, MP_QSTR_pre_gain);
-
-    // If we did not receive a BlockInput we need to create a default float value
-    if (post_gain == MP_OBJ_NULL) {
-        post_gain = mp_obj_new_float(0.0);
-    }
     synthio_block_assign_slot(post_gain, &self->post_gain, MP_QSTR_post_gain);
+    synthio_block_assign_slot(mix, &self->mix, MP_QSTR_mix);
 
     self->mode = mode;
-
-    // If we did not receive a BlockInput we need to create a default float value
-    if (mix == MP_OBJ_NULL) {
-        mix = mp_obj_new_float(1.0);
-    }
-    synthio_block_assign_slot(mix, &self->mix, MP_QSTR_mix);
 }
 
 bool common_hal_audiofilters_distortion_deinited(audiofilters_distortion_obj_t *self) {