Fix I2C bug in ports/analog/busio

- Add clear flags + Shutdown/Init to I2C constructor
- Explicitly set frequency
- Add failsafe in probe function if MST mode disabled
  (can happen in some error conditions)

- Fix Makefile bug with missing "\" for source files

Signed-off-by: Brandon-Hurst <[email protected]>

Author: Brandon-Hurst

ports/analog/Makefile

@@ -125,7 +125,7 @@ SRC_MAX32 += \
 	$(PERIPH_SRC)/UART/uart_$(DIE_TYPE).c \
 	$(PERIPH_SRC)/UART/uart_revb.c \
 	$(PERIPH_SRC)/TRNG/trng_revb.c \
-	$(PERIPH_SRC)/TRNG/trng_$(DIE_TYPE).c
+	$(PERIPH_SRC)/TRNG/trng_$(DIE_TYPE).c \
 	$(PERIPH_SRC)/I2C/i2c_$(DIE_TYPE).c \
 	$(PERIPH_SRC)/I2C/i2c_reva.c \
 	$(PERIPH_SRC)/SPI/spi_$(DIE_TYPE).c \

ports/analog/common-hal/busio/I2C.c

@@ -76,6 +76,16 @@ void common_hal_busio_i2c_construct(busio_i2c_obj_t *self,
     common_hal_mcu_pin_claim(self->sda);
     common_hal_mcu_pin_claim(self->scl);
 
+    // Clear all flags
+    MXC_I2C_ClearFlags(self->i2c_regs, 0xFFFFFF, 0xFFFFFF);
+
+    // Init as master, no slave address
+    MXC_I2C_Shutdown(self->i2c_regs);
+    MXC_I2C_Init(self->i2c_regs, 1, 0);
+
+    // Set frequency arg (CircuitPython shared-bindings validate)
+    MXC_I2C_SetFrequency(self->i2c_regs, frequency);
+
     // Indicate to this module that the I2C is active
     i2c_active |= (1 << self->i2c_id);
 
@@ -116,6 +126,11 @@ bool common_hal_busio_i2c_probe(busio_i2c_obj_t *self, uint8_t addr) {
     uint32_t int_fl0;
     bool ret = 0;
 
+    // If not in Master mode, error out (can happen in some error conditions)
+    if (!(self->i2c_regs->ctrl & MXC_F_I2C_CTRL_MST_MODE)) {
+        return false;
+    }
+
     // Clear FIFOs & all interrupt flags
     MXC_I2C_ClearRXFIFO(self->i2c_regs);
     MXC_I2C_ClearTXFIFO(self->i2c_regs);
@@ -175,7 +190,6 @@ void common_hal_busio_i2c_unlock(busio_i2c_obj_t *self) {
 }
 
 // Write data to the device selected by address
-// todo test
 uint8_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
     const uint8_t *data, size_t len) {
 
@@ -221,7 +235,7 @@ uint8_t common_hal_busio_i2c_read(busio_i2c_obj_t *self,
     return 0;
 }
 
-// Write the bytes from out_data to the device selected by address,
+// Write the bytes from out_data to the device selected by address
 uint8_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
     uint8_t *out_data, size_t out_len,
     uint8_t *in_data, size_t in_len) {