Disallow tile=0

jepler · jepler · commit 189ec2fc60f8 · 2021-01-26T16:51:31.000-06:00
diff --git a/locale/circuitpython.pot b/locale/circuitpython.pot
@@ -3711,7 +3711,7 @@ msgid "threshold must be in the range 0-65536"
 msgstr ""
 
 #: shared-bindings/rgbmatrix/RGBMatrix.c
-msgid "tile must be greater than or equal to zero"
+msgid "tile must be greater than zero"
 msgstr ""
 
 #: shared-bindings/time/__init__.c
diff --git a/shared-bindings/rgbmatrix/RGBMatrix.c b/shared-bindings/rgbmatrix/RGBMatrix.c
@@ -214,9 +214,9 @@ STATIC mp_obj_t rgbmatrix_rgbmatrix_make_new(const mp_obj_type_t *type, size_t n
 
     int tile = args[ARG_tile].u_int;
 
-    if (tile < 0) {
+    if (tile <= 0) {
         mp_raise_ValueError_varg(
-            translate("tile must be greater than or equal to zero"));
+            translate("tile must be greater than zero"));
     }
 
     int computed_height = (rgb_count / 3) * (1 << (addr_count)) * tile;

Original file line number	Diff line number	Diff line change
`@@ -214,9 +214,9 @@ STATIC mp_obj_t rgbmatrix_rgbmatrix_make_new(const mp_obj_type_t *type, size_t n`
`214`	`214`
`215`	`215`	`int tile = args[ARG_tile].u_int;`
`216`	`216`
`217`		`- if (tile < 0) {`
	`217`	`+ if (tile <= 0) {`
`218`	`218`	`mp_raise_ValueError_varg(`
`219`		`- translate("tile must be greater than or equal to zero"));`
	`219`	`+ translate("tile must be greater than zero"));`
`220`	`220`	`}`
`221`	`221`
`222`	`222`	`int computed_height = (rgb_count / 3) * (1 << (addr_count)) * tile;`