Skip to content

Commit 2284211

Browse files
committed
Merge remote-tracking branch 'adafruit/main' into rpi-auto-disconnect
2 parents c3cf7c0 + 4ea0e47 commit 2284211

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

docs/shared_bindings_matrix.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,11 @@ def get_settings_from_makefile(port_dir, board_name):
170170
This means that the effect of all Makefile directives is taken
171171
into account, without having to re-encode the logic that sets them
172172
in this script, something that has proved error-prone
173+
174+
This list must explicitly include any setting queried by tools/ci_set_matrix.py.
173175
"""
174176
contents = subprocess.run(
175-
["make", "-C", port_dir, "-f", "Makefile", f"BOARD={board_name}", "print-CFLAGS", "print-CIRCUITPY_BUILD_EXTENSIONS", "print-FROZEN_MPY_DIRS", "print-SRC_PATTERNS"],
177+
["make", "-C", port_dir, "-f", "Makefile", f"BOARD={board_name}", "print-CFLAGS", "print-CIRCUITPY_BUILD_EXTENSIONS", "print-FROZEN_MPY_DIRS", "print-SRC_PATTERNS", "print-SRC_SUPERVISOR"],
176178
encoding="utf-8",
177179
errors="replace",
178180
stdout=subprocess.PIPE,

tools/ci_set_matrix.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -189,23 +189,20 @@ def get_settings(board):
189189

190190
# Check frozen files to see if they are in each board
191191
if file.startswith("frozen"):
192-
if file in settings.get("FROZEN_MPY_DIRS", ""):
192+
if file in settings["FROZEN_MPY_DIRS"]:
193193
boards_to_build.add(board)
194194
continue
195195

196196
# Check supervisor files
197197
# This is useful for limiting workflow changes to the relevant boards
198198
if file.startswith("supervisor"):
199-
if file in settings.get("SRC_SUPERVISOR", ""):
199+
if file in settings["SRC_SUPERVISOR"]:
200200
boards_to_build.add(board)
201201
continue
202202

203203
if file.startswith("supervisor/shared/web_workflow/static/"):
204204
web_workflow = settings["CIRCUITPY_WEB_WORKFLOW"]
205205

206-
while web_workflow.startswith("$("):
207-
web_workflow = settings[web_workflow[2:-1]]
208-
209206
if web_workflow != "0":
210207
boards_to_build.add(board)
211208
continue

0 commit comments

Comments
 (0)