Skip to content

Commit 23ba58b

Browse files
committed
Gamepad & GamepadShift: Initially allocate as long-lived
This makes less heap churn and decreases code size a tiny bit
1 parent fbf052b commit 23ba58b

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

shared-bindings/gamepad/GamePad.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,8 @@ STATIC mp_obj_t gamepad_make_new(const mp_obj_type_t *type, size_t n_args,
106106
gamepad_obj_t* gamepad_singleton = MP_STATE_VM(gamepad_singleton);
107107
if (!gamepad_singleton ||
108108
!MP_OBJ_IS_TYPE(MP_OBJ_FROM_PTR(gamepad_singleton), &gamepad_type)) {
109-
gamepad_singleton = m_new_obj(gamepad_obj_t);
109+
gamepad_singleton = m_new_ll_obj(gamepad_obj_t);
110110
gamepad_singleton->base.type = &gamepad_type;
111-
gamepad_singleton = gc_make_long_lived(gamepad_singleton);
112111
if (!MP_STATE_VM(gamepad_singleton)) {
113112
supervisor_enable_tick();
114113
}

shared-bindings/gamepadshift/GamePadShift.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,8 @@ STATIC mp_obj_t gamepadshift_make_new(const mp_obj_type_t *type, size_t n_args,
7373
if (!gamepad_singleton ||
7474
!MP_OBJ_IS_TYPE(MP_OBJ_FROM_PTR(gamepad_singleton),
7575
&gamepadshift_type)) {
76-
gamepad_singleton = m_new_obj(gamepadshift_obj_t);
76+
gamepad_singleton = m_new_ll_obj(gamepadshift_obj_t);
7777
gamepad_singleton->base.type = &gamepadshift_type;
78-
gamepad_singleton = gc_make_long_lived(gamepad_singleton);
7978
if (!MP_STATE_VM(gamepad_singleton)) {
8079
supervisor_enable_tick();
8180
}

0 commit comments

Comments
 (0)