OnDiskBitmap: Fix memory corruption when using palette image

jepler · jepler · commit 2556fce862a9 · 2021-07-19T09:25:26.000-05:00
The number of palette entries set was accidentally 4x too much,
because the wrong looping variable was used.
diff --git a/shared-module/displayio/OnDiskBitmap.c b/shared-module/displayio/OnDiskBitmap.c
@@ -108,7 +108,7 @@ void common_hal_displayio_ondiskbitmap_construct(displayio_ondiskbitmap_t *self,
             if (palette_bytes_read != palette_size) {
                 mp_raise_ValueError(translate("Unable to read color palette data"));
             }
-            for (uint16_t i = 0; i < palette_size; i++) {
+            for (uint16_t i = 0; i < number_of_colors; i++) {
                 common_hal_displayio_palette_set_color(palette, i, palette_data[i]);
             }
             m_free(palette_data);

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ void common_hal_displayio_ondiskbitmap_construct(displayio_ondiskbitmap_t *self,`
`108`	`108`	`if (palette_bytes_read != palette_size) {`
`109`	`109`	`mp_raise_ValueError(translate("Unable to read color palette data"));`
`110`	`110`	`}`
`111`		`- for (uint16_t i = 0; i < palette_size; i++) {`
	`111`	`+ for (uint16_t i = 0; i < number_of_colors; i++) {`
`112`	`112`	`common_hal_displayio_palette_set_color(palette, i, palette_data[i]);`
`113`	`113`	`}`
`114`	`114`	`m_free(palette_data);`