Skip to content

Commit 2fc372b

Browse files
durapensatannewt
andauthored
Lolin S2 Mini - Apply suggestions from code review
Co-authored-by: Scott Shawcroft <[email protected]>
1 parent 15fc44c commit 2fc372b

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@
2929
#define MICROPY_HW_BOARD_NAME "S2Mini"
3030
#define MICROPY_HW_MCU_NAME "ESP32S2-S2FN4R2" // from Wemos MP
3131

32-
// #define MICROPY_HW_NEOPIXEL (&pin_GPIO1) // no NeoPixel on S2 Mini
33-
// #define CIRCUITPY_STATUS_LED_POWER (&pin_GPIO15)
3432
#define CIRCUITPY_BOOT_BUTTON (&pin_GPIO0)
3533
#define BOARD_USER_SAFE_MODE_ACTION translate("pressing boot button at start up.\n")
3634

@@ -43,5 +41,3 @@
4341
#define DEFAULT_SPI_BUS_MOSI (&pin_GPIO11) // no SPI labels on S2 Mini, def from Wemos MP
4442
#define DEFAULT_SPI_BUS_MISO (&pin_GPIO9) // no SPI labels on S2 Mini, def from Wemos MP
4543

46-
// #define DEFAULT_UART_BUS_RX (&pin_GPIO44) // no UART pins on S2 Mini
47-
// #define DEFAULT_UART_BUS_TX (&pin_GPIO43) // no UART pins on S2 Mini

ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ CIRCUITPY_ESP_FLASH_MODE=qio
1414
CIRCUITPY_ESP_FLASH_FREQ=80m
1515
CIRCUITPY_ESP_FLASH_SIZE=4MB
1616

17-
# CIRCUITPY_BITBANG_NEOPIXEL = 1 # no NeoPixel on S2 Mini
1817

1918
# Include these Python libraries in firmware.
2019
FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_NeoPixel

0 commit comments

Comments
 (0)