fix old bug that was masking new bug

Author: anecdata

locale/circuitpython.pot

@@ -683,7 +683,7 @@ msgid "Can't set CCCD on local Characteristic"
 msgstr ""
 
 #: ports/espressif/common-hal/wifi/Radio.c
-msgid "Can't set MAC address while connected"
+msgid "Station must be started"
 msgstr ""
 
 #: shared-bindings/storage/__init__.c shared-bindings/usb_cdc/__init__.c

ports/espressif/common-hal/wifi/Radio.c

@@ -121,8 +121,8 @@ mp_obj_t common_hal_wifi_radio_get_mac_address(wifi_radio_obj_t *self) {
 }
 
 void common_hal_wifi_radio_set_mac_address(wifi_radio_obj_t *self, const uint8_t *mac) {
-    if (self->sta_mode) {
-        mp_raise_RuntimeError(translate("Can't set MAC address while connected"));
+    if (!self->sta_mode) {
+        mp_raise_RuntimeError(translate("Station must be started"));
     }
     if ((mac[0] & 0b1) == 0b1) {
         mp_raise_RuntimeError(translate("Invalid multicast MAC address"));

ports/espressif/common-hal/wifi/__init__.c

@@ -152,7 +152,7 @@ void common_hal_wifi_init(void) {
         mp_raise_RuntimeError(translate("Failed to init wifi"));
     }
     // set station mode to avoid the default SoftAP
-    esp_wifi_set_mode(WIFI_MODE_STA);
+    common_hal_wifi_radio_start_station(self);
     // start wifi
     common_hal_wifi_radio_set_enabled(self, true);
 }

shared-bindings/wifi/Radio.c

@@ -118,8 +118,8 @@ const mp_obj_property_t wifi_radio_hostname_obj = {
 };
 
 //|     mac_address: ReadableBuffer
-//|     """MAC address of the wifi radio station.
-//|        Can only be set while the Station is not started."""
+//|     """MAC address for the station. When the address is altered after interface is connected
+//|        the changes would only be reflected once the interface reconnects."""
 //|
 STATIC mp_obj_t wifi_radio_get_mac_address(mp_obj_t self_in) {
     wifi_radio_obj_t *self = MP_OBJ_TO_PTR(self_in);