Skip to content

Commit 33e90ba

Browse files
committed
Fix pid and clean comments
1 parent d638aa0 commit 33e90ba

File tree

2 files changed

+6
-30
lines changed

2 files changed

+6
-30
lines changed

ports/espressif/boards/m5stack_atoms3/board.c

Lines changed: 5 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -37,40 +37,16 @@ displayio_fourwire_obj_t board_display_obj;
3737

3838
#define DELAY 0x80
3939

40-
// display init sequence according to LilyGO example app
40+
// display init sequence according to ST7789
4141
uint8_t display_init_sequence[] = {
42-
// sw reset
43-
0x01, 0 | DELAY, 0x96,
44-
// sleep out
45-
0x11, 0 | DELAY, 0xff,
46-
// normal display mode on
47-
// 0x13, 0,
48-
// display and color format settings
49-
// 0x36, 1, 0x68,
50-
// 0xB6, 2, 0x0A, 0x82,
51-
0x3A, 1 | DELAY, 0x55, 0x0a,
42+
0x01, 0 | DELAY, 0x96, // _SWRESET and Delay 150ms
43+
0x11, 0 | DELAY, 0xff, // _SLPOUT and Delay 500ms
44+
0x3A, 1 | DELAY, 0x55, 0x0a, // _COLMOD and Delay 10ms
5245
0x36, 0x01, 0x08, // _MADCTL
5346
0x21, 0x80, 0x0A, // _INVON Hack and Delay 10ms
5447
0x13, 0x80, 0x0A, // _NORON and Delay 10ms
5548
0x36, 0x01, 0xC0, // _MADCTL
56-
// ST7789V frame rate setting
57-
// 0xB2, 5, 0x0C, 0x0C, 0x00, 0x33, 0x33,
58-
// voltages: VGH / VGL
59-
// 0xB7, 1, 0x35,
60-
// ST7789V power setting
61-
// 0xBB, 1, 0x28,
62-
// 0xC0, 1, 0x0C,
63-
// 0xC2, 2, 0x01, 0xFF,
64-
// 0xC3, 1, 0x10,
65-
// 0xC4, 1, 0x20,
66-
// 0xC6, 1, 0x0F,
67-
// 0xD0, 2, 0xA4, 0xA1,
68-
// ST7789V gamma setting
69-
// 0xE0, 14, 0xD0, 0x00, 0x02, 0x07, 0x0A, 0x28, 0x32, 0x44, 0x42, 0x06, 0x0E, 0x12, 0x14, 0x17,
70-
// 0xE1, 14, 0xD0, 0x00, 0x02, 0x07, 0x0A, 0x28, 0x31, 0x54, 0x47, 0x0E, 0x1C, 0x17, 0x1B, 0x1E,
71-
// 0x21, 0,
72-
// display on
73-
0x29, 0 | DELAY, 0xff
49+
0x29, 0 | DELAY, 0xff // _DISPON and Delay 500ms
7450
};
7551

7652

ports/espressif/boards/m5stack_atoms3/mpconfigboard.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
USB_VID = 0x303A
2-
USB_PID = 0x815F
2+
USB_PID = 0x8120
33
USB_PRODUCT = "M5Stack AtomS3"
44
USB_MANUFACTURER = "M5Stack"
55

0 commit comments

Comments
 (0)