Add tools files for debugging

- Add debug-dap.sh to spawn OpenOCD process & gdb-multiarch process for debugging.
  Requires MaximSDK install & path settings inside this script.
  Also depends on gdb-multiarch and connected CMSIS-DAP probe over USB.
- debug-dap.gdb simply holds the gdb commands for this script

+ small style fix on common-hal/microcontroller/Pin.c

Author: Brandon-Hurst

ports/analog/common-hal/microcontroller/Pin.c

@@ -37,7 +37,7 @@ void reset_all_pins(void) {
 }
 
 void reset_pin_number(uint8_t pin_port, uint8_t pin_pad) {
-    if (pin_port == INVALID_PIN || pin_port > NUM_GPIO_PORTS) {
+    if ( (pin_port == INVALID_PIN) || (pin_port > NUM_GPIO_PORTS) ) {
         return;
     }
 

ports/analog/tools/debug-dap.gdb

@@ -0,0 +1,3 @@
+target remote :3333
+break main
+continue

ports/analog/tools/debug-dap.sh

@@ -0,0 +1,23 @@
+#!/bin/bash
+
+# Primer on taking cmd line args in Linux shell scripts
+# $0 is the script itself
+# $1 $2 $3 are arg1, arg2, arg3, etc
+
+# Export OCD Path
+### USER ACTION: Replace with your path to OpenOCD ###
+OCD_PATH="~/MaximSDK/Tools/OpenOCD"
+
+# Call openocd to setup the debug server, storing the PID for OpenOCD
+sh -c "openocd -s $OCD_PATH/scripts -f interface/cmsis-dap.cfg -f target/$1.cfg -c \"init; reset halt\" " &
+
+# Allow enough time for OCD server to set up
+# + wait for the sleep to finish
+sleep 3 &
+wait $!
+
+# spawn the gdb process and store the gdb_pid
+gdb-multiarch build-apard32690/firmware.elf -x "tools/debug-dap.gdb"
+
+# when gdb exits, kill all openocd processes
+killall openocd