Cleanup copy-paste comments in MAX32 busio files

Signed-off-by: Brandon Hurst <[email protected]>

Author: Brandon-Hurst

ports/analog/common-hal/busio/I2C.c

@@ -40,32 +40,14 @@ typedef enum {
     I2C_NEVER_RESET,
 } i2c_status_t;
 
-// Set each bit to indicate an active UART
-// will be checked by ISR Handler for which ones to call
+// Set each bit to indicate an active I2c
 static uint8_t i2c_active = 0;
 static i2c_status_t i2c_status[NUM_I2C];
 static volatile int i2c_err;
 
 // I2C struct for configuring GPIO pins
 extern const mxc_gpio_cfg_t i2c_maps[NUM_I2C];
 
-// I2C Interrupt Handler
-void i2c_isr(void) {
-    for (int i = 0; i < NUM_I2C; i++) {
-        if (i2c_active & (1 << i)) {
-            // NOTE: I2C_GET_TMR actually returns the I2C registers
-            MXC_I2C_AsyncHandler(MXC_I2C_GET_I2C(i));
-        }
-    }
-}
-
-// Callback gets called when AsyncRequest is COMPLETE
-// (e.g. txLen == txCnt)
-// static volatile void i2cCallback(mxc_i2c_req_t *req, int error) {
-//     i2c_status[MXC_I2C_GET_IDX(req->i2c)] = I2C_FREE;
-//     i2c_err = error;
-// }
-
 // Construct I2C protocol, this function init i2c peripheral
 void common_hal_busio_i2c_construct(busio_i2c_obj_t *self,
     const mcu_pin_obj_t *scl,
@@ -80,7 +62,6 @@ void common_hal_busio_i2c_construct(busio_i2c_obj_t *self,
     // Assign I2C ID based on pins
     temp = pinsToI2c(sda, scl);
     if (temp == -1) {
-        // Error will be indicated by pinsToUart(tx, rx) function
         return;
     } else {
         self->i2c_id = temp;
@@ -124,12 +105,6 @@ void common_hal_busio_i2c_construct(busio_i2c_obj_t *self,
         self->timeout = timeout;
     }
 
-    /* Setup I2C interrupt */
-    NVIC_ClearPendingIRQ(MXC_I2C_GET_IRQ(self->i2c_id));
-    NVIC_DisableIRQ(MXC_I2C_GET_IRQ(self->i2c_id));
-    NVIC_SetPriority(MXC_I2C_GET_IRQ(self->i2c_id), I2C_PRIORITY);
-    NVIC_SetVector(MXC_I2C_GET_IRQ(self->i2c_id), (uint32_t)i2c_isr);
-
     return;
 }
 

ports/analog/common-hal/busio/I2C.h

@@ -7,7 +7,6 @@
 #pragma once
 
 #include "common-hal/microcontroller/Pin.h"
-// FIXME: Silabs includes "peripherals/periph.h. Figure out what's in this file. "
 #include "py/obj.h"
 
 // HAL-specific

ports/analog/common-hal/busio/SPI.c

@@ -46,36 +46,24 @@ typedef enum {
 } spi_status_t;
 
 // Set each bit to indicate an active SPI
-// will be checked by ISR Handler for which ones to call
 static uint8_t spi_active = 0;
 static spi_status_t spi_status[NUM_SPI];
 static volatile int spi_err;
 
-// SPI Interrupt Handler
-void spi_isr(void) {
-    for (int i = 0; i < NUM_SPI; i++) {
-        if (spi_active & (1 << i)) {
-            MXC_SPI_AsyncHandler(MXC_SPI_GET_SPI(i));
-        }
-    }
-}
-
 // Construct SPI protocol, this function init SPI peripheral
-// todo: figure out Chip select behavior
 void common_hal_busio_spi_construct(busio_spi_obj_t *self,
     const mcu_pin_obj_t *sck,
     const mcu_pin_obj_t *mosi,
     const mcu_pin_obj_t *miso,
     bool half_duplex) {
     int temp, err = 0;
 
-    // Check for NULL Pointers && valid I2C settings
+    // Check for NULL Pointer
     assert(self);
 
-    // Assign I2C ID based on pins
+    // Assign SPI ID based on pins
     temp = pinsToSpi(mosi, miso, sck);
     if (temp == -1) {
-        // Error will be indicated by pinsToUart(tx, rx) function
         return;
     } else {
         self->spi_id = temp;
@@ -120,12 +108,6 @@ void common_hal_busio_spi_construct(busio_spi_obj_t *self,
     // Indicate to this module that the SPI is active
     spi_active |= (1 << self->spi_id);
 
-    /* Setup I2C interrupt */
-    NVIC_ClearPendingIRQ(MXC_SPI_GET_IRQ(self->spi_id));
-    NVIC_DisableIRQ(MXC_SPI_GET_IRQ(self->spi_id));
-    NVIC_SetPriority(MXC_SPI_GET_IRQ(self->spi_id), SPI_PRIORITY);
-    NVIC_SetVector(MXC_SPI_GET_IRQ(self->spi_id), (uint32_t)spi_isr);
-
     return;
 }
 

ports/analog/common-hal/busio/SPI.h

@@ -8,7 +8,6 @@
 #define MICROPY_INCLUDED_MAX32_COMMON_HAL_BUSIO_SPI_H
 
 #include "common-hal/microcontroller/Pin.h"
-// FIXME: Silabs includes "peripherals/periph.h. Figure out what's in this file. "
 #include "py/obj.h"
 
 // HAL-specific

ports/analog/common-hal/busio/UART.c

@@ -167,7 +167,8 @@ void common_hal_busio_uart_construct(busio_uart_obj_t *self,
     const mcu_pin_obj_t *rts, const mcu_pin_obj_t *cts,
     const mcu_pin_obj_t *rs485_dir, bool rs485_invert,
     uint32_t baudrate, uint8_t bits, busio_uart_parity_t parity, uint8_t stop,
-    mp_float_t timeout, bool sigint_enabled) {
+    mp_float_t timeout, uint16_t receiver_buffer_size, byte *receiver_buffer,
+    bool sigint_enabled) {
     int err, temp;
 
     // Check for NULL Pointers && valid UART settings

ports/analog/common-hal/busio/UART.h

@@ -9,11 +9,6 @@
 
 #include "common-hal/microcontroller/Pin.h"
 #include "py/obj.h"
-#include "py/ringbuf.h"
-
-// #include "uart.h"
-// #include "uart_regs.h"
-// #include "mxc_sys.h"
 
 #include "max32_port.h"