Skip to content

Commit 40c3b5c

Browse files
committed
docs(swan_r5):todo cleanup
1 parent 88f6bb2 commit 40c3b5c

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

ports/stm/common-hal/busio/I2C.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
// I2C timing specs for the H7 and F7
3838
// Configured for maximum possible clock settings for the family
39-
#if (CPY_STM32F7) // todo - get the correct values for the L4
39+
#if (CPY_STM32F7)
4040
#ifndef CPY_I2CFAST_TIMINGR
4141
#define CPY_I2CFAST_TIMINGR 0x6000030D
4242
#endif

ports/stm/peripherals/stm32l4/stm32l4r5xx/periph.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ const mcu_periph_obj_t mcu_uart_rx_list[UART_RX_ARRAY_LEN] = {
165165
PERIPH(1, 7, &pin_PG10),
166166
};
167167

168-
// todo
169168
// Timers
170169
// TIM6 and TIM7 are basic timers that are only used by DAC, and don't have pins
171170
TIM_TypeDef *mcu_tim_banks[TIM_BANK_ARRAY_LEN] = {TIM1, TIM2, TIM3, TIM4, TIM5, TIM15, TIM16};

ports/stm/supervisor/internal_flash.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ STATIC uint8_t _flash_cache[0x20000] __attribute__((aligned(4)));
9696

9797
#elif defined(STM32L4)
9898
// todo - the L4 devices can have different flash sizes and different page sizes
99-
// depending upon the configuration
100-
// This is hardcoded for the Blues Swan. When support for other devices is needed more conditionals will be required
99+
// depending upon the dual bank configuration
100+
// This is hardcoded for the Swan R5. When support for other devices is needed more conditionals will be required
101101
// to differentiate.
102102
STATIC const flash_layout_t flash_layout[] = {
103103
{ 0x08000000, 0x1000, 256 },
@@ -170,7 +170,7 @@ uint32_t flash_get_sector_info(uint32_t addr, uint32_t *start_addr, uint32_t *si
170170
}
171171
}
172172
}
173-
return 0; // todo dangerous - shouldn't this raise an exception
173+
return 0; // todo dangerous - shouldn't this raise an exception?
174174
}
175175

176176
void supervisor_flash_init(void) {

0 commit comments

Comments
 (0)