Apply suggestions from code review

timhawes · tannewt · web-flow · commit 54e87d366096 · 2021-12-14T20:03:44.000Z
Co-authored-by: Scott Shawcroft &lt;scott@tannewt.org&gt;
diff --git a/ports/espressif/common-hal/ssl/SSLContext.c b/ports/espressif/common-hal/ssl/SSLContext.c
@@ -81,17 +81,9 @@ void common_hal_ssl_sslcontext_set_default_verify_paths(ssl_sslcontext_obj_t *se
 }
 
 bool common_hal_ssl_sslcontext_get_check_hostname(ssl_sslcontext_obj_t *self) {
-    if (self->ssl_config.skip_common_name) {
-        return 0;
-    } else {
-        return 1;
-    }
+    return !self->ssl_config.skip_common_name;
 }
 
 void common_hal_ssl_sslcontext_set_check_hostname(ssl_sslcontext_obj_t *self, bool value) {
-    if (value) {
-        self->ssl_config.skip_common_name = 0;
-    } else {
-        self->ssl_config.skip_common_name = 1;
-    }
+    self->ssl_config.skip_common_name = !value;
 }

Original file line number	Diff line number	Diff line change
`@@ -81,17 +81,9 @@ void common_hal_ssl_sslcontext_set_default_verify_paths(ssl_sslcontext_obj_t *se`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`bool common_hal_ssl_sslcontext_get_check_hostname(ssl_sslcontext_obj_t *self) {`
`84`		`- if (self->ssl_config.skip_common_name) {`
`85`		`- return 0;`
`86`		`- } else {`
`87`		`- return 1;`
`88`		`- }`
	`84`	`+ return !self->ssl_config.skip_common_name;`
`89`	`85`	`}`
`90`	`86`
`91`	`87`	`void common_hal_ssl_sslcontext_set_check_hostname(ssl_sslcontext_obj_t *self, bool value) {`
`92`		`- if (value) {`
`93`		`- self->ssl_config.skip_common_name = 0;`
`94`		`- } else {`
`95`		`- self->ssl_config.skip_common_name = 1;`
`96`		`- }`
	`88`	`+ self->ssl_config.skip_common_name = !value;`
`97`	`89`	`}`