Only delay when explicitly called for

jepler · jepler · commit 5a60b8d573cf · 2023-09-18T12:58:54.000-05:00
diff --git a/shared-module/dotclockframebuffer/__init__.c b/shared-module/dotclockframebuffer/__init__.c
@@ -66,15 +66,14 @@ void dotclockframebuffer_ioexpander_send_init_sequence(dotclockframebuffer_ioexp
         // deassert CS
         pin_change(bus, /* set */ bus->cs_mask, 0);
 
-        uint16_t delay_length_ms = 10;
         if (delay) {
             data_size++;
-            delay_length_ms = *(cmd + 1 + data_size);
+            uint16_t delay_length_ms = *(cmd + 1 + data_size);
             if (delay_length_ms == 255) {
                 delay_length_ms = 500;
             }
+            mp_hal_delay_ms(delay_length_ms);
         }
-        mp_hal_delay_ms(delay_length_ms);
         i += 2 + data_size;
     }
     common_hal_busio_i2c_unlock(bus->bus);

Original file line number	Diff line number	Diff line change
`@@ -66,15 +66,14 @@ void dotclockframebuffer_ioexpander_send_init_sequence(dotclockframebuffer_ioexp`
`66`	`66`	`// deassert CS`
`67`	`67`	`pin_change(bus, /* set */ bus->cs_mask, 0);`
`68`	`68`
`69`		`- uint16_t delay_length_ms = 10;`
`70`	`69`	`if (delay) {`
`71`	`70`	`data_size++;`
`72`		`- delay_length_ms = *(cmd + 1 + data_size);`
	`71`	`+ uint16_t delay_length_ms = *(cmd + 1 + data_size);`
`73`	`72`	`if (delay_length_ms == 255) {`
`74`	`73`	`delay_length_ms = 500;`
`75`	`74`	`}`
	`75`	`+ mp_hal_delay_ms(delay_length_ms);`
`76`	`76`	`}`
`77`		`- mp_hal_delay_ms(delay_length_ms);`
`78`	`77`	`i += 2 + data_size;`
`79`	`78`	`}`
`80`	`79`	`common_hal_busio_i2c_unlock(bus->bus);`