esp32s2: Introduce, use NO_PIN

jepler · jepler · commit 6750d3feab5b · 2021-05-26T11:18:02.000-05:00
GPIO_NUM_NC is -1 so it's equivalent to the existing code.
diff --git a/ports/esp32s2/common-hal/microcontroller/Pin.c b/ports/esp32s2/common-hal/microcontroller/Pin.c
@@ -51,7 +51,7 @@ STATIC void floating_gpio_reset(gpio_num_t pin_number) {
 }
 
 void never_reset_pin_number(gpio_num_t pin_number) {
-    if (pin_number == -1) {
+    if (pin_number == NO_PIN) {
         return;
     }
     never_reset_pins[pin_number / 32] |= 1 << pin_number % 32;
@@ -63,7 +63,7 @@ void common_hal_never_reset_pin(const mcu_pin_obj_t *pin) {
 
 // Mark pin as free and return it to a quiescent state.
 void reset_pin_number(gpio_num_t pin_number) {
-    if (pin_number == -1) {
+    if (pin_number == NO_PIN) {
         return;
     }
     never_reset_pins[pin_number / 32] &= ~(1 << pin_number % 32);
diff --git a/ports/esp32s2/peripherals/pins.h b/ports/esp32s2/peripherals/pins.h
@@ -91,4 +91,6 @@ extern const mcu_pin_obj_t pin_GPIO44;
 extern const mcu_pin_obj_t pin_GPIO45;
 extern const mcu_pin_obj_t pin_GPIO46;
 
+#define NO_PIN (GPIO_NUM_NC)
+
 #endif // MICROPY_INCLUDED_ESP32S2_PERIPHERALS_PINS_H

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ STATIC void floating_gpio_reset(gpio_num_t pin_number) {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`void never_reset_pin_number(gpio_num_t pin_number) {`
`54`		`- if (pin_number == -1) {`
	`54`	`+ if (pin_number == NO_PIN) {`
`55`	`55`	`return;`
`56`	`56`	`}`
`57`	`57`	`never_reset_pins[pin_number / 32] \|= 1 << pin_number % 32;`
`@@ -63,7 +63,7 @@ void common_hal_never_reset_pin(const mcu_pin_obj_t *pin) {`
`63`	`63`
`64`	`64`	`// Mark pin as free and return it to a quiescent state.`
`65`	`65`	`void reset_pin_number(gpio_num_t pin_number) {`
`66`		`- if (pin_number == -1) {`
	`66`	`+ if (pin_number == NO_PIN) {`
`67`	`67`	`return;`
`68`	`68`	`}`
`69`	`69`	`never_reset_pins[pin_number / 32] &= ~(1 << pin_number % 32);`