Skip to content

Commit 6dc179d

Browse files
committed
Removed old supervisor stack setting code and revert some 'optimisations'
1 parent a61a9f4 commit 6dc179d

File tree

3 files changed

+18
-50
lines changed

3 files changed

+18
-50
lines changed

locale/circuitpython.pot

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,20 @@ msgid ""
3535
"https://github.com/adafruit/circuitpython/issues\n"
3636
msgstr ""
3737

38+
#: main.c
39+
msgid ""
40+
"\n"
41+
"WARNING: Allocating pystack failed, defaulting back to build value.\n"
42+
"\n"
43+
msgstr ""
44+
45+
#: main.c
46+
msgid ""
47+
"\n"
48+
"WARNING: Invalid CIRCUITPY_PYSTACK_SIZE, defaulting back to build value.\n"
49+
"\n"
50+
msgstr ""
51+
3852
#: py/obj.c
3953
msgid " File \"%q\""
4054
msgstr ""
@@ -376,12 +390,6 @@ msgstr ""
376390
msgid "*x must be assignment target"
377391
msgstr ""
378392

379-
#: main.c
380-
msgid ""
381-
", defaulting back to build value.\n"
382-
"\n"
383-
msgstr ""
384-
385393
#: py/obj.c
386394
msgid ", in %q\n"
387395
msgstr ""
@@ -488,10 +496,6 @@ msgstr ""
488496
msgid "All timers in use"
489497
msgstr ""
490498

491-
#: main.c
492-
msgid "Allocating pystack failed"
493-
msgstr ""
494-
495499
#: ports/espressif/common-hal/_bleio/Adapter.c
496500
#: ports/nrf/common-hal/_bleio/Adapter.c
497501
msgid "Already advertising."
@@ -1240,10 +1244,6 @@ msgstr ""
12401244
msgid "Invalid BSSID"
12411245
msgstr ""
12421246

1243-
#: main.c
1244-
msgid "Invalid CIRCUITPY_PYSTACK_SIZE"
1245-
msgstr ""
1246-
12471247
#: shared-bindings/wifi/Radio.c
12481248
msgid "Invalid MAC address"
12491249
msgstr ""
@@ -2363,7 +2363,7 @@ msgid "Voltage read timed out"
23632363
msgstr ""
23642364

23652365
#: main.c
2366-
msgid "WARNING: "
2366+
msgid "WARNING: Your code filename has two extensions\n"
23672367
msgstr ""
23682368

23692369
#: ports/atmel-samd/common-hal/watchdog/WatchDogTimer.c
@@ -2424,10 +2424,6 @@ msgid ""
24242424
"You pressed the reset button during boot. Press again to exit safe mode."
24252425
msgstr ""
24262426

2427-
#: main.c
2428-
msgid "Your code filename has two extensions\n"
2429-
msgstr ""
2430-
24312427
#: supervisor/shared/micropython.c
24322428
msgid "[truncated due to length]"
24332429
msgstr ""

main.c

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -150,19 +150,13 @@ STATIC vm_memory_t allocate_vm_memory(void) {
150150
// Check if value is valid
151151
pystack_size = pystack_size - pystack_size % sizeof(size_t); // Round down to multiple of 4.
152152
if (pystack_size < 384) {
153-
serial_write("\n");
154-
serial_write_compressed(translate("WARNING: "));
155-
serial_write_compressed(translate("Invalid CIRCUITPY_PYSTACK_SIZE"));
156-
serial_write_compressed(translate(", defaulting back to build value.\n\n"));
153+
serial_write_compressed(translate("\nWARNING: Invalid CIRCUITPY_PYSTACK_SIZE, defaulting back to build value.\n\n"));
157154
pystack_size = CIRCUITPY_PYSTACK_SIZE; // Reset
158155
}
159156
#endif
160157
res.pystack = allocate_memory(pystack_size, false, false);
161158
if (res.pystack == NULL) {
162-
serial_write("\n");
163-
serial_write_compressed(translate("WARNING: "));
164-
serial_write_compressed(translate("Allocating pystack failed"));
165-
serial_write_compressed(translate(", defaulting back to build value.\n\n"));
159+
serial_write_compressed(translate("\nWARNING: Allocating pystack failed, defaulting back to build value.\n\n"));
166160
res.pystack = allocate_memory(CIRCUITPY_PYSTACK_SIZE, false, false);
167161
}
168162
#endif
@@ -471,8 +465,7 @@ STATIC bool run_code_py(safe_mode_t safe_mode, bool *simulate_reset) {
471465
if (!found_main) {
472466
found_main = maybe_run_list(double_extension_filenames, MP_ARRAY_SIZE(double_extension_filenames));
473467
if (found_main) {
474-
serial_write_compressed(translate("WARNING: "));
475-
serial_write_compressed(translate("Your code filename has two extensions\n"));
468+
serial_write_compressed(translate("WARNING: Your code filename has two extensions\n"));
476469
}
477470
}
478471
#else

shared-bindings/supervisor/Runtime.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -168,26 +168,6 @@ MP_PROPERTY_GETSET(supervisor_runtime_ble_workflow_obj,
168168
(mp_obj_t)&supervisor_runtime_get_ble_workflow_obj,
169169
(mp_obj_t)&supervisor_runtime_set_ble_workflow_obj);
170170

171-
//| next_stack_limit: int
172-
//| """The size of the stack for the next vm run. If its too large, the default will be used."""
173-
//|
174-
STATIC mp_obj_t supervisor_runtime_get_next_stack_limit(mp_obj_t self) {
175-
return mp_obj_new_int(get_next_stack_size());
176-
}
177-
MP_DEFINE_CONST_FUN_OBJ_1(supervisor_runtime_get_next_stack_limit_obj, supervisor_runtime_get_next_stack_limit);
178-
179-
STATIC mp_obj_t supervisor_runtime_set_next_stack_limit(mp_obj_t self, mp_obj_t size_obj) {
180-
mp_int_t size = mp_obj_get_int(size_obj);
181-
mp_arg_validate_int_min(size, 256, MP_QSTR_size);
182-
set_next_stack_size(size);
183-
return mp_const_none;
184-
}
185-
MP_DEFINE_CONST_FUN_OBJ_2(supervisor_runtime_set_next_stack_limit_obj, supervisor_runtime_set_next_stack_limit);
186-
187-
MP_PROPERTY_GETSET(supervisor_runtime_next_stack_limit_obj,
188-
(mp_obj_t)&supervisor_runtime_get_next_stack_limit_obj,
189-
(mp_obj_t)&supervisor_runtime_set_next_stack_limit_obj);
190-
191171
//| rgb_status_brightness: int
192172
//| """Set brightness of status RGB LED from 0-255. This will take effect
193173
//| after the current code finishes and the status LED is used to show
@@ -220,7 +200,6 @@ STATIC const mp_rom_map_elem_t supervisor_runtime_locals_dict_table[] = {
220200
{ MP_ROM_QSTR(MP_QSTR_run_reason), MP_ROM_PTR(&supervisor_runtime_run_reason_obj) },
221201
{ MP_ROM_QSTR(MP_QSTR_autoreload), MP_ROM_PTR(&supervisor_runtime_autoreload_obj) },
222202
{ MP_ROM_QSTR(MP_QSTR_ble_workflow), MP_ROM_PTR(&supervisor_runtime_ble_workflow_obj) },
223-
{ MP_ROM_QSTR(MP_QSTR_next_stack_limit), MP_ROM_PTR(&supervisor_runtime_next_stack_limit_obj) },
224203
{ MP_ROM_QSTR(MP_QSTR_rgb_status_brightness), MP_ROM_PTR(&supervisor_runtime_rgb_status_brightness_obj) },
225204
};
226205

0 commit comments

Comments
 (0)