Skip to content

Commit 7969638

Browse files
committed
SSLSocket: Add stream protocol
including select. This assumes that the SSL layer is readable/writable exactly when the underlying socket is readable/writable.
1 parent 5d9129a commit 7969638

File tree

3 files changed

+70
-3
lines changed

3 files changed

+70
-3
lines changed

shared-bindings/ssl/SSLSocket.c

Lines changed: 53 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,11 @@
1010
#include <string.h>
1111

1212
#include "shared/runtime/context_manager_helpers.h"
13-
#include "py/objtuple.h"
13+
#include "py/mperrno.h"
1414
#include "py/objlist.h"
15+
#include "py/objtuple.h"
1516
#include "py/runtime.h"
16-
#include "py/mperrno.h"
17+
#include "py/stream.h"
1718

1819
#include "shared/netutils/netutils.h"
1920

@@ -247,9 +248,58 @@ static const mp_rom_map_elem_t ssl_sslsocket_locals_dict_table[] = {
247248

248249
static MP_DEFINE_CONST_DICT(ssl_sslsocket_locals_dict, ssl_sslsocket_locals_dict_table);
249250

251+
static mp_uint_t sslsocket_read(mp_obj_t self_in, void *buf, mp_uint_t size, int *errorcode) {
252+
ssl_sslsocket_obj_t *self = MP_OBJ_TO_PTR(self_in);
253+
mp_int_t ret = common_hal_ssl_sslsocket_recv_into(self, buf, size);
254+
if (ret < 0) {
255+
*errorcode = -ret;
256+
return MP_STREAM_ERROR;
257+
}
258+
return ret;
259+
}
260+
261+
static mp_uint_t sslsocket_write(mp_obj_t self_in, const void *buf, mp_uint_t size, int *errorcode) {
262+
ssl_sslsocket_obj_t *self = MP_OBJ_TO_PTR(self_in);
263+
mp_int_t ret = common_hal_ssl_sslsocket_send(self, buf, size);
264+
if (ret < 0) {
265+
*errorcode = -ret;
266+
return MP_STREAM_ERROR;
267+
}
268+
return ret;
269+
}
270+
271+
static mp_uint_t sslsocket_ioctl(mp_obj_t self_in, mp_uint_t request, mp_uint_t arg, int *errcode) {
272+
ssl_sslsocket_obj_t *self = MP_OBJ_TO_PTR(self_in);
273+
mp_uint_t ret;
274+
if (request == MP_STREAM_POLL) {
275+
mp_uint_t flags = arg;
276+
ret = 0;
277+
if ((flags & MP_STREAM_POLL_RD) && common_hal_ssl_sslsocket_readable(self) > 0) {
278+
ret |= MP_STREAM_POLL_RD;
279+
}
280+
if ((flags & MP_STREAM_POLL_WR) && common_hal_ssl_sslsocket_writable(self)) {
281+
ret |= MP_STREAM_POLL_WR;
282+
}
283+
} else {
284+
*errcode = MP_EINVAL;
285+
ret = MP_STREAM_ERROR;
286+
}
287+
return ret;
288+
}
289+
290+
291+
static const mp_stream_p_t sslsocket_stream_p = {
292+
.read = sslsocket_read,
293+
.write = sslsocket_write,
294+
.ioctl = sslsocket_ioctl,
295+
.is_text = false,
296+
};
297+
298+
250299
MP_DEFINE_CONST_OBJ_TYPE(
251300
ssl_sslsocket_type,
252301
MP_QSTR_SSLSocket,
253302
MP_TYPE_FLAG_NONE,
254-
locals_dict, &ssl_sslsocket_locals_dict
303+
locals_dict, &ssl_sslsocket_locals_dict,
304+
protocol, &sslsocket_stream_p
255305
);

shared-bindings/ssl/SSLSocket.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ void common_hal_ssl_sslsocket_close(ssl_sslsocket_obj_t *self);
2020
void common_hal_ssl_sslsocket_connect(ssl_sslsocket_obj_t *self, mp_obj_t addr);
2121
bool common_hal_ssl_sslsocket_get_closed(ssl_sslsocket_obj_t *self);
2222
bool common_hal_ssl_sslsocket_get_connected(ssl_sslsocket_obj_t *self);
23+
bool common_hal_ssl_sslsocket_readable(ssl_sslsocket_obj_t *self);
24+
bool common_hal_ssl_sslsocket_writable(ssl_sslsocket_obj_t *self);
2325
void common_hal_ssl_sslsocket_listen(ssl_sslsocket_obj_t *self, int backlog);
2426
mp_uint_t common_hal_ssl_sslsocket_recv_into(ssl_sslsocket_obj_t *self, uint8_t *buf, uint32_t len);
2527
mp_uint_t common_hal_ssl_sslsocket_send(ssl_sslsocket_obj_t *self, const uint8_t *buf, uint32_t len);

shared-module/ssl/SSLSocket.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -448,3 +448,18 @@ void common_hal_ssl_sslsocket_setsockopt(ssl_sslsocket_obj_t *self, mp_obj_t lev
448448
void common_hal_ssl_sslsocket_settimeout(ssl_sslsocket_obj_t *self, mp_obj_t timeout_obj) {
449449
ssl_socket_settimeout(self, timeout_obj);
450450
}
451+
452+
static bool poll_common(ssl_sslsocket_obj_t *self, int mode) {
453+
const mp_stream_p_t *stream_p = mp_get_stream_raise(self->sock_obj, MP_STREAM_OP_IOCTL);
454+
int errcode;
455+
mp_int_t ret = stream_p->ioctl(self->sock_obj, MP_STREAM_POLL, mode, &errcode);
456+
return ret != 0;
457+
}
458+
459+
bool common_hal_ssl_sslsocket_readable(ssl_sslsocket_obj_t *self) {
460+
return poll_common(self, MP_STREAM_POLL_RD);
461+
}
462+
463+
bool common_hal_ssl_sslsocket_writable(ssl_sslsocket_obj_t *self) {
464+
return poll_common(self, MP_STREAM_POLL_WR);
465+
}

0 commit comments

Comments
 (0)