Skip to content

Commit 8107c9b

Browse files
committed
extmod/nimble: Remove TODO comment about notify_custom freeing om.
The comments in NimBLE for ble_gattc_notify_custom() state that "This function consumes the supplied mbuf regardless of the outcome.". And inspection of NimBLE code shows that this is the case. So the comment can be removed. Signed-off-by: Damien George <[email protected]>
1 parent 514bf1a commit 8107c9b

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

extmod/nimble/modbluetooth_nimble.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1030,7 +1030,6 @@ int mp_bluetooth_gatts_notify_send(uint16_t conn_handle, uint16_t value_handle,
10301030
if (om == NULL) {
10311031
return MP_ENOMEM;
10321032
}
1033-
// TODO: check that notify_custom takes ownership of om, if not os_mbuf_free_chain(om).
10341033
return ble_hs_err_to_errno(ble_gattc_notify_custom(conn_handle, value_handle, om));
10351034
}
10361035

0 commit comments

Comments
 (0)