Skip to content

Commit 8993356

Browse files
committed
remove unused mp_board_init() and board_gc_collect() per review comments
1 parent 1630f21 commit 8993356

File tree

3 files changed

+0
-19
lines changed

3 files changed

+0
-19
lines changed

main.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,6 @@ static void start_mp(safe_mode_t safe_mode) {
207207

208208
// Always return to root
209209
common_hal_os_chdir("/");
210-
211-
// Initialization for individual boards when a VM starts.
212-
mp_board_init();
213210
}
214211

215212
static void stop_mp(void) {
@@ -1152,7 +1149,6 @@ void gc_collect(void) {
11521149
gc_collect_root((void **)&MP_STATE_VM(vfs_mount_table), sizeof(mp_vfs_mount_t) / sizeof(mp_uint_t));
11531150

11541151
port_gc_collect();
1155-
board_gc_collect();
11561152

11571153
background_callback_gc_collect();
11581154

supervisor/board.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,3 @@ void reset_board(void);
2525
// state. It should not prevent the user access method from working (such as
2626
// disabling USB, BLE or flash) because CircuitPython may continue to run.
2727
void board_deinit(void);
28-
29-
// Initialization for individual boards when a VM starts.
30-
void mp_board_init(void);
31-
32-
// Some boards may want to mark additional pointers as gc roots.
33-
// A default weak implementation is provided that does nothing.
34-
void board_gc_collect(void);

supervisor/shared/board.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,3 @@ MP_WEAK void board_deinit(void) {
4444
// Do-nothing so not all boards need to provide this function.
4545
MP_WEAK void reset_board(void) {
4646
}
47-
48-
// Do-nothing so not all boards need to provide this function.
49-
MP_WEAK void mp_board_init(void) {
50-
}
51-
52-
// Do-nothing so not all boards need to provide this function.
53-
MP_WEAK void board_gc_collect(void) {
54-
}

0 commit comments

Comments
 (0)