Merge pull request #8169 from jepler/os-getenv-exception

tannewt · web-flow · commit 8de9d5a52259 · 2023-07-13T10:49:42.000-07:00
throw an exception if os.getenv is used on a board without settings.t…
diff --git a/shared-bindings/os/__init__.c b/shared-bindings/os/__init__.c
@@ -103,7 +103,7 @@ STATIC mp_obj_t os_getenv(size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_
 
     return common_hal_os_getenv(mp_obj_str_get_str(args[ARG_key].u_obj), args[ARG_default].u_obj);
     #else
-    return mp_const_none;
+    mp_raise_NotImplementedError(NULL);
     #endif
 }
 STATIC MP_DEFINE_CONST_FUN_OBJ_KW(os_getenv_obj, 1, os_getenv);

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ STATIC mp_obj_t os_getenv(size_t n_args, const mp_obj_t pos_args, mp_map_t kw_`
`103`	`103`
`104`	`104`	`return common_hal_os_getenv(mp_obj_str_get_str(args[ARG_key].u_obj), args[ARG_default].u_obj);`
`105`	`105`	`#else`
`106`		`- return mp_const_none;`
	`106`	`+ mp_raise_NotImplementedError(NULL);`
`107`	`107`	`#endif`
`108`	`108`	`}`
`109`	`109`	`STATIC MP_DEFINE_CONST_FUN_OBJ_KW(os_getenv_obj, 1, os_getenv);`