protomatter: improve an error message

jepler · jepler · commit 9019710a1e75 · 2020-04-14T18:24:58.000-05:00
diff --git a/shared-bindings/_protomatter/Protomatter.c b/shared-bindings/_protomatter/Protomatter.c
@@ -54,7 +54,7 @@ STATIC uint8_t validate_pin(mp_obj_t obj) {
 STATIC void validate_pins(qstr what, uint8_t* pin_nos, mp_int_t max_pins, mp_obj_t seq, uint8_t *count_out) {
     mp_int_t len = MP_OBJ_SMALL_INT_VALUE(mp_obj_len(seq));
     if (len > max_pins) {
-        mp_raise_ValueError_varg(translate("At most %d %q may be specified"), max_pins, what);
+        mp_raise_ValueError_varg(translate("At most %d %q may be specified (not %d)"), max_pins, what, len);
     }
     *count_out = len;
     for (mp_int_t i=0; i<len; i++) {

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ STATIC uint8_t validate_pin(mp_obj_t obj) {`
`54`	`54`	`STATIC void validate_pins(qstr what, uint8_t* pin_nos, mp_int_t max_pins, mp_obj_t seq, uint8_t *count_out) {`
`55`	`55`	`mp_int_t len = MP_OBJ_SMALL_INT_VALUE(mp_obj_len(seq));`
`56`	`56`	`if (len > max_pins) {`
`57`		`- mp_raise_ValueError_varg(translate("At most %d %q may be specified"), max_pins, what);`
	`57`	`+ mp_raise_ValueError_varg(translate("At most %d %q may be specified (not %d)"), max_pins, what, len);`
`58`	`58`	`}`
`59`	`59`	`*count_out = len;`
`60`	`60`	`for (mp_int_t i=0; i<len; i++) {`