Change 12- to 16-bit scaling to match other ports

PaintYourDragon · web-flow · commit 92fa02effa95 · 2022-05-24T08:49:05.000-07:00
Result is identical, implementation just resembles other ports instead of being all 1337 about it.
diff --git a/ports/mimxrt10xx/common-hal/analogio/AnalogIn.c b/ports/mimxrt10xx/common-hal/analogio/AnalogIn.c
@@ -81,8 +81,10 @@ uint16_t common_hal_analogio_analogin_get_value(analogio_analogin_obj_t *self) {
 
     }
 
-    // Stretch 12-bit ADC reading to 16 bits via 24-bit interim result
-    return (ADC_GetChannelConversionValue(self->pin->adc, ADC_CHANNEL_GROUP) * 0x1001) >> 8;
+    uint16_t value = ADC_GetChannelConversionValue(self->pin->adc, ADC_CHANNEL_GROUP);
+
+    // Stretch 12-bit ADC reading to 16-bit range
+    return (value << 4) | (value >> 8);
 }
 
 float common_hal_analogio_analogin_get_reference_voltage(analogio_analogin_obj_t *self) {

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,10 @@ uint16_t common_hal_analogio_analogin_get_value(analogio_analogin_obj_t *self) {`
`81`	`81`
`82`	`82`	`}`
`83`	`83`
`84`		`- // Stretch 12-bit ADC reading to 16 bits via 24-bit interim result`
`85`		`- return (ADC_GetChannelConversionValue(self->pin->adc, ADC_CHANNEL_GROUP) * 0x1001) >> 8;`
	`84`	`+ uint16_t value = ADC_GetChannelConversionValue(self->pin->adc, ADC_CHANNEL_GROUP);`
	`85`	`+`
	`86`	`+ // Stretch 12-bit ADC reading to 16-bit range`
	`87`	`+ return (value << 4) \| (value >> 8);`
`86`	`88`	`}`
`87`	`89`
`88`	`90`	`float common_hal_analogio_analogin_get_reference_voltage(analogio_analogin_obj_t *self) {`