never_reset_pin: Move pin validity check before first use of pin number

jepler · jepler · commit a770b5a91933 · 2020-06-22T10:45:27.000-05:00
diff --git a/ports/atmel-samd/common-hal/microcontroller/Pin.c b/ports/atmel-samd/common-hal/microcontroller/Pin.c
@@ -110,12 +110,12 @@ void never_reset_pin_number(uint8_t pin_number) {
 }
 
 void reset_pin_number(uint8_t pin_number) {
-    never_reset_pins[GPIO_PORT(pin_number)] &= ~(1 << GPIO_PIN(pin_number));
-
     if (pin_number >= PORT_BITS) {
         return;
     }
 
+    never_reset_pins[GPIO_PORT(pin_number)] &= ~(1 << GPIO_PIN(pin_number));
+
     #ifdef MICROPY_HW_NEOPIXEL
     if (pin_number == MICROPY_HW_NEOPIXEL->number) {
         neopixel_in_use = false;

Original file line number	Diff line number	Diff line change
`@@ -110,12 +110,12 @@ void never_reset_pin_number(uint8_t pin_number) {`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`void reset_pin_number(uint8_t pin_number) {`
`113`		`- never_reset_pins[GPIO_PORT(pin_number)] &= ~(1 << GPIO_PIN(pin_number));`
`114`		`-`
`115`	`113`	`if (pin_number >= PORT_BITS) {`
`116`	`114`	`return;`
`117`	`115`	`}`
`118`	`116`
	`117`	`+ never_reset_pins[GPIO_PORT(pin_number)] &= ~(1 << GPIO_PIN(pin_number));`
	`118`	`+`
`119`	`119`	`#ifdef MICROPY_HW_NEOPIXEL`
`120`	`120`	`if (pin_number == MICROPY_HW_NEOPIXEL->number) {`
`121`	`121`	`neopixel_in_use = false;`