Merge pull request #2961 from arturo182/i2c-exception

arturo182 · web-flow · commit ad988013f0ef · 2020-05-27T11:24:46.000+02:00
mimxrt10xx: Change exception type to match other ports
diff --git a/ports/mimxrt10xx/common-hal/busio/I2C.c b/ports/mimxrt10xx/common-hal/busio/I2C.c
@@ -81,7 +81,7 @@ void common_hal_busio_i2c_construct(busio_i2c_obj_t *self,
     }
 
     if(self->sda_pin == NULL || self->scl_pin == NULL) {
-        mp_raise_RuntimeError(translate("Invalid I2C pin selection"));
+        mp_raise_ValueError(translate("Invalid I2C pin selection"));
     } else {
         self->i2c = mcu_i2c_banks[self->sda_pin->bank_idx - 1];
     }

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ void common_hal_busio_i2c_construct(busio_i2c_obj_t *self,`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`if(self->sda_pin == NULL \|\| self->scl_pin == NULL) {`
`84`		`- mp_raise_RuntimeError(translate("Invalid I2C pin selection"));`
	`84`	`+ mp_raise_ValueError(translate("Invalid I2C pin selection"));`
`85`	`85`	`} else {`
`86`	`86`	`self->i2c = mcu_i2c_banks[self->sda_pin->bank_idx - 1];`
`87`	`87`	`}`