Pico W: Correctly treat empty cadata= as disabling host checking

jepler · jepler · commit b1f794029746 · 2022-10-12T11:38:29.000-05:00
diff --git a/ports/raspberrypi/common-hal/ssl/SSLContext.c b/ports/raspberrypi/common-hal/ssl/SSLContext.c
@@ -42,7 +42,7 @@ void common_hal_ssl_sslcontext_load_verify_locations(ssl_sslcontext_obj_t *self,
     self->crt_bundle_attach = NULL;
     self->use_global_ca_store = false;
     self->cacert_buf = (const unsigned char *)cadata;
-    self->cacert_bytes = strlen(cadata) + 1;
+    self->cacert_bytes = *cadata ? strlen(cadata) + 1 : 0;
 }
 
 void common_hal_ssl_sslcontext_set_default_verify_paths(ssl_sslcontext_obj_t *self) {

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ void common_hal_ssl_sslcontext_load_verify_locations(ssl_sslcontext_obj_t *self,`
`42`	`42`	`self->crt_bundle_attach = NULL;`
`43`	`43`	`self->use_global_ca_store = false;`
`44`	`44`	`self->cacert_buf = (const unsigned char *)cadata;`
`45`		`- self->cacert_bytes = strlen(cadata) + 1;`
	`45`	`+ self->cacert_bytes = *cadata ? strlen(cadata) + 1 : 0;`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`void common_hal_ssl_sslcontext_set_default_verify_paths(ssl_sslcontext_obj_t *self) {`