Skip to content

Commit b3a449c

Browse files
committed
Turn on json and enable socket.close
1 parent 430530c commit b3a449c

File tree

3 files changed

+4
-27
lines changed

3 files changed

+4
-27
lines changed

ports/esp32s2/mpconfigport.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
#define CIRCUITPY_INTERNAL_NVM_SIZE (0)
3232
#define MICROPY_NLR_THUMB (0)
3333

34-
#define MICROPY_PY_UJSON (0)
34+
#define MICROPY_PY_UJSON (1)
3535
#define MICROPY_USE_INTERNAL_PRINTF (0)
3636

3737
#include "py/circuitpy_mpconfig.h"

shared-bindings/socketpool/Socket.c

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -155,32 +155,8 @@ STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(socketpool_socket___exit___obj, 4, 4,
155155
//| """Closes this Socket and makes its resources available to its SocketPool."""
156156
//|
157157
STATIC mp_obj_t socketpool_socket_close(mp_obj_t self_in) {
158-
// mod_network_socket_obj_t *self = MP_OBJ_TO_PTR(self_in);
159-
160-
// // create new socket object
161-
// // starts with empty NIC so that finaliser doesn't run close() method if accept() fails
162-
// mod_network_socket_obj_t *socket2 = m_new_obj_with_finaliser(mod_network_socket_obj_t);
163-
// socket2->base.type = &socket_type;
164-
// socket2->nic = MP_OBJ_NULL;
165-
// socket2->nic_type = NULL;
166-
167-
// // accept incoming connection
168-
// uint8_t ip[MOD_NETWORK_IPADDR_BUF_SIZE];
169-
// mp_uint_t port;
170-
// int _errno;
171-
// if (self->nic_type->accept(self, socket2, ip, &port, &_errno) != 0) {
172-
// mp_raise_OSError(_errno);
173-
// }
174-
175-
// // new socket has valid state, so set the NIC to the same as parent
176-
// socket2->nic = self->nic;
177-
// socket2->nic_type = self->nic_type;
178-
179-
// // make the return value
180-
// mp_obj_tuple_t *client = MP_OBJ_TO_PTR(mp_obj_new_tuple(2, NULL));
181-
// client->items[0] = MP_OBJ_FROM_PTR(socket2);
182-
// client->items[1] = netutils_format_inet_addr(ip, port, NETUTILS_BIG);
183-
158+
socketpool_socket_obj_t *self = MP_OBJ_TO_PTR(self_in);
159+
common_hal_socketpool_socket_close(self);
184160
return mp_const_none;
185161
}
186162
STATIC MP_DEFINE_CONST_FUN_OBJ_1(socketpool_socket_close_obj, socketpool_socket_close);

shared-bindings/socketpool/Socket.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,6 @@ void common_hal_socketpool_socket_settimeout(socketpool_socket_obj_t* self, mp_u
3535
bool common_hal_socketpool_socket_connect(socketpool_socket_obj_t* self, const char* host, size_t hostlen, mp_int_t port);
3636
mp_uint_t common_hal_socketpool_socket_send(socketpool_socket_obj_t* self, const uint8_t* buf, mp_uint_t len);
3737
mp_uint_t common_hal_socketpool_socket_recv_into(socketpool_socket_obj_t* self, const uint8_t* buf, mp_uint_t len);
38+
void common_hal_socketpool_socket_close(socketpool_socket_obj_t* self);
3839

3940
#endif // MICROPY_INCLUDED_SHARED_BINDINGS_SOCKETPOOL_SOCKET_H

0 commit comments

Comments
 (0)