Skip to content

Commit c96d142

Browse files
committed
Remove unnecessary m_malloc_fail and deinit from memory allocation routines.
1 parent 5f8ec0a commit c96d142

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

shared-module/audiofilters/Filter.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -28,27 +28,15 @@ void common_hal_audiofilters_filter_construct(audiofilters_filter_obj_t *self,
2828
self->buffer_len = buffer_size; // in bytes
2929

3030
self->buffer[0] = m_malloc(self->buffer_len);
31-
if (self->buffer[0] == NULL) {
32-
common_hal_audiofilters_filter_deinit(self);
33-
m_malloc_fail(self->buffer_len);
34-
}
3531
memset(self->buffer[0], 0, self->buffer_len);
3632

3733
self->buffer[1] = m_malloc(self->buffer_len);
38-
if (self->buffer[1] == NULL) {
39-
common_hal_audiofilters_filter_deinit(self);
40-
m_malloc_fail(self->buffer_len);
41-
}
4234
memset(self->buffer[1], 0, self->buffer_len);
4335

4436
self->last_buf_idx = 1; // Which buffer to use first, toggle between 0 and 1
4537

4638
// This buffer will be used to process samples through the biquad filter
4739
self->filter_buffer = m_malloc(SYNTHIO_MAX_DUR * sizeof(int32_t));
48-
if (self->filter_buffer == NULL) {
49-
common_hal_audiofilters_filter_deinit(self);
50-
m_malloc_fail(SYNTHIO_MAX_DUR * sizeof(int32_t));
51-
}
5240
memset(self->filter_buffer, 0, SYNTHIO_MAX_DUR * sizeof(int32_t));
5341

5442
// Initialize other values most effects will need.
@@ -106,10 +94,6 @@ void reset_filter_states(audiofilters_filter_obj_t *self) {
10694
}
10795

10896
self->filter_states = m_malloc(self->filter_states_len * sizeof(biquad_filter_state));
109-
if (self->filter_states == NULL) {
110-
common_hal_audiofilters_filter_deinit(self);
111-
m_malloc_fail(self->filter_states_len * sizeof(biquad_filter_state));
112-
}
11397

11498
if (mp_obj_is_type(items, (const mp_obj_type_t *)&synthio_biquad_type_obj)) {
11599
synthio_biquad_filter_assign(&self->filter_states[0], items);

0 commit comments

Comments
 (0)