Skip to content

Commit c96e27e

Browse files
authored
Merge pull request #9516 from tannewt/remove_new_errors_from_aurora
Remove unique error messages
2 parents 26f682d + 4950beb commit c96e27e

File tree

2 files changed

+4
-22
lines changed

2 files changed

+4
-22
lines changed

locale/circuitpython.pot

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1187,10 +1187,12 @@ msgstr ""
11871187
#: ports/raspberrypi/common-hal/picodvi/Framebuffer_RP2040.c py/argcheck.c
11881188
#: shared-bindings/digitalio/DigitalInOut.c
11891189
#: shared-bindings/epaperdisplay/EPaperDisplay.c shared-bindings/pwmio/PWMOut.c
1190+
#: shared-module/aurora_epaper/aurora_framebuffer.c
11901191
msgid "Invalid %q"
11911192
msgstr ""
11921193

11931194
#: ports/raspberrypi/common-hal/picodvi/Framebuffer_RP2350.c
1195+
#: shared-module/aurora_epaper/aurora_framebuffer.c
11941196
msgid "Invalid %q and %q"
11951197
msgstr ""
11961198

@@ -1214,11 +1216,6 @@ msgstr ""
12141216
msgid "Invalid BSSID"
12151217
msgstr ""
12161218

1217-
#: shared-module/aurora_epaper/aurora_framebuffer.c
1218-
#, c-format
1219-
msgid "Invalid CoG id=%d"
1220-
msgstr ""
1221-
12221219
#: shared-bindings/wifi/Radio.c
12231220
msgid "Invalid MAC address"
12241221
msgstr ""
@@ -2166,14 +2163,6 @@ msgstr ""
21662163
msgid "Unknown BLE error: %d"
21672164
msgstr ""
21682165

2169-
#: shared-module/aurora_epaper/aurora_framebuffer.c
2170-
msgid "Unknown device size."
2171-
msgstr ""
2172-
2173-
#: shared-module/aurora_epaper/aurora_framebuffer.c
2174-
msgid "Unknown display type!"
2175-
msgstr ""
2176-
21772166
#: ports/espressif/common-hal/max3421e/Max3421E.c
21782167
#: ports/raspberrypi/common-hal/wifi/__init__.c
21792168
#, c-format
@@ -2231,10 +2220,6 @@ msgstr ""
22312220
msgid "Unsupported colorspace"
22322221
msgstr ""
22332222

2234-
#: shared-module/aurora_epaper/aurora_framebuffer.c
2235-
msgid "Unsupported device size."
2236-
msgstr ""
2237-
22382223
#: shared-module/displayio/bus_core.c
22392224
msgid "Unsupported display bus type"
22402225
msgstr ""

shared-module/aurora_epaper/aurora_framebuffer.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ void common_hal_aurora_epaper_framebuffer_construct(
6363
} else if (width == 232 && height == 128) {
6464
self->type = LARGE_2_6;
6565
} else {
66-
mp_raise_TypeError(MP_ERROR_TEXT("Unsupported device size."));
66+
mp_raise_ValueError_varg(MP_ERROR_TEXT("Invalid %q and %q"), MP_QSTR_width, MP_QSTR_height);
6767
}
6868

6969
// CS
@@ -235,7 +235,7 @@ bool common_hal_aurora_epaper_framebuffer_power_on(aurora_epaper_framebuffer_obj
235235

236236
if (cog_id != 0x12) {
237237
common_hal_busio_spi_unlock(self->bus);
238-
mp_raise_ValueError_varg(MP_ERROR_TEXT("Invalid CoG id=%d"), cog_id);
238+
mp_raise_RuntimeError_varg(MP_ERROR_TEXT("Invalid %q"), MP_QSTR_id);
239239
return false;
240240
}
241241

@@ -261,7 +261,6 @@ bool common_hal_aurora_epaper_framebuffer_power_on(aurora_epaper_framebuffer_obj
261261
break;
262262
default:
263263
common_hal_busio_spi_unlock(self->bus);
264-
mp_raise_ValueError(MP_ERROR_TEXT("Unknown display type!"));
265264
return false;
266265
}
267266

@@ -523,8 +522,6 @@ void common_hal_aurora_epaper_framebuffer_draw_line(aurora_epaper_framebuffer_ob
523522
common_hal_busio_spi_write(self->bus, &border, 1);
524523

525524
#undef DO_MAP
526-
} else {
527-
mp_raise_TypeError(MP_ERROR_TEXT("Unknown device size."));
528525
}
529526

530527
common_hal_digitalio_digitalinout_set_value(&self->chip_select, true);

0 commit comments

Comments
 (0)