Skip to content

Commit dd03d4f

Browse files
authored
Merge pull request #9513 from tannewt/rp2350_rgbmatrix
Enable RGBMatrix on RP2350
2 parents 65a40f5 + ee2f7bd commit dd03d4f

File tree

10 files changed

+2
-16
lines changed

10 files changed

+2
-16
lines changed

ports/raspberrypi/boards/adafruit_feather_rp2350/mpconfigboard.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ CHIP_FAMILY = rp2
1010
EXTERNAL_FLASH_DEVICES = "GD25Q64C,W25Q64JVxQ"
1111

1212
CIRCUITPY_ALARM = 0
13-
CIRCUITPY_RGBMATRIX = 0
1413

1514
CIRCUITPY_FLOPPYIO = 0
1615
CIRCUITPY_PICODVI = 1

ports/raspberrypi/boards/adafruit_metro_rp2350/mpconfigboard.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ CHIP_FAMILY = rp2
1010
EXTERNAL_FLASH_DEVICES = "W25Q128JVxQ"
1111

1212
CIRCUITPY_ALARM = 0
13-
CIRCUITPY_RGBMATRIX = 0

ports/raspberrypi/boards/cytron_iriv_io_controller/mpconfigboard.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ EXTERNAL_FLASH_DEVICES = "W25Q16JVxQ"
1111

1212
CIRCUITPY__EVE = 1
1313
CIRCUITPY_ALARM = 0
14-
CIRCUITPY_RGBMATRIX = 0
1514

1615
# Include these Python libraries in firmware.
1716
FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_SimpleIO

ports/raspberrypi/boards/cytron_motion_2350_pro/mpconfigboard.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ EXTERNAL_FLASH_DEVICES = "W25Q16JVxQ"
1111

1212
CIRCUITPY__EVE = 1
1313
CIRCUITPY_ALARM = 0
14-
CIRCUITPY_RGBMATRIX = 0
1514

1615
# Include these Python libraries in firmware.
1716
FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_NeoPixel

ports/raspberrypi/boards/raspberry_pi_pico2/mpconfigboard.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,3 @@ EXTERNAL_FLASH_DEVICES = "W25Q32JVxQ"
1111

1212
CIRCUITPY__EVE = 1
1313
CIRCUITPY_ALARM = 0
14-
CIRCUITPY_RGBMATRIX = 0

ports/raspberrypi/boards/solderparty_rp2350_stamp/mpconfigboard.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ EXTERNAL_FLASH_DEVICES = "W25Q128JVxQ"
1111

1212
CIRCUITPY__EVE = 1
1313
CIRCUITPY_ALARM = 0
14-
CIRCUITPY_RGBMATRIX = 0
1514
CIRCUITPY_PICODVI = 1
1615

1716
FROZEN_MPY_DIRS += $(TOP)/ports/raspberrypi/boards/solderparty_rp2040_stamp

ports/raspberrypi/boards/solderparty_rp2350_stamp_xl/mpconfigboard.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ EXTERNAL_FLASH_DEVICES = "W25Q128JVxQ"
1111

1212
CIRCUITPY__EVE = 1
1313
CIRCUITPY_ALARM = 0
14-
CIRCUITPY_RGBMATRIX = 0
1514
CIRCUITPY_PICODVI = 1
1615

1716
FROZEN_MPY_DIRS += $(TOP)/ports/raspberrypi/boards/solderparty_rp2040_stamp

ports/raspberrypi/common-hal/picodvi/Framebuffer_RP2350.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ static void __not_in_flash_func(dma_irq_handler)(void) {
119119
if (active_picodvi == NULL) {
120120
return;
121121
}
122-
// gpio_put(10, 1);
123122
uint ch_num = active_picodvi->dma_pixel_channel;
124123
dma_channel_hw_t *ch = &dma_hw->ch[ch_num];
125124
dma_hw->intr = 1u << ch_num;
@@ -128,7 +127,6 @@ static void __not_in_flash_func(dma_irq_handler)(void) {
128127
// will trigger the pixel channel).
129128
ch = &dma_hw->ch[active_picodvi->dma_command_channel];
130129
ch->al3_read_addr_trig = (uintptr_t)active_picodvi->dma_commands;
131-
// gpio_put(10, 0);
132130
}
133131

134132
void common_hal_picodvi_framebuffer_construct(picodvi_framebuffer_obj_t *self,
@@ -392,11 +390,6 @@ void common_hal_picodvi_framebuffer_construct(picodvi_framebuffer_obj_t *self,
392390
never_reset_pin_number(i);
393391
}
394392

395-
// gpio_init(10);
396-
// gpio_put(10, 0);
397-
// gpio_set_dir(10, GPIO_OUT);
398-
// never_reset_pin_number(10);
399-
400393
dma_channel_config c;
401394
c = dma_channel_get_default_config(self->dma_command_channel);
402395
channel_config_set_transfer_data_size(&c, DMA_SIZE_32);

0 commit comments

Comments
 (0)