Fix error that would carry past python exception

hierophect · hierophect · commit dfe73a063d5a · 2019-11-05T10:50:57.000-05:00
diff --git a/ports/stm32f4/common-hal/analogio/AnalogOut.c b/ports/stm32f4/common-hal/analogio/AnalogOut.c
@@ -60,7 +60,6 @@ void common_hal_analogio_analogout_construct(analogio_analogout_obj_t* self,
     } else {
         mp_raise_ValueError(translate("Invalid DAC pin supplied"));
     }
-    dac_on[self->dac_index] = true;
 
     //Only init if the shared DAC is empty or reset
     if (handle.Instance == NULL || handle.State == HAL_DAC_STATE_RESET) {
@@ -85,6 +84,7 @@ void common_hal_analogio_analogout_construct(analogio_analogout_obj_t* self,
         mp_raise_ValueError(translate("DAC Channel Init Error"));
     }
 
+    dac_on[self->dac_index] = true;
     self->pin = pin;
     claim_pin(pin);
     #endif

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,6 @@ void common_hal_analogio_analogout_construct(analogio_analogout_obj_t* self,`
`60`	`60`	`} else {`
`61`	`61`	`mp_raise_ValueError(translate("Invalid DAC pin supplied"));`
`62`	`62`	`}`
`63`		`- dac_on[self->dac_index] = true;`
`64`	`63`
`65`	`64`	`//Only init if the shared DAC is empty or reset`
`66`	`65`	`if (handle.Instance == NULL \|\| handle.State == HAL_DAC_STATE_RESET) {`
`@@ -85,6 +84,7 @@ void common_hal_analogio_analogout_construct(analogio_analogout_obj_t* self,`
`85`	`84`	`mp_raise_ValueError(translate("DAC Channel Init Error"));`
`86`	`85`	`}`
`87`	`86`
	`87`	`+ dac_on[self->dac_index] = true;`
`88`	`88`	`self->pin = pin;`
`89`	`89`	`claim_pin(pin);`
`90`	`90`	`#endif`