Skip to content

Commit e40abda

Browse files
committed
ci_set_matrix: Don't use .get(), it hides errors
Variables that are explicitly fetched always have a value, even if it is the empty value. However, using .get() hid the error that shared_bindings_matrix wasn't fetching SRC_SUPERVISOR.
1 parent c261ac6 commit e40abda

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/ci_set_matrix.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,14 +189,14 @@ def get_settings(board):
189189

190190
# Check frozen files to see if they are in each board
191191
if file.startswith("frozen"):
192-
if file in settings.get("FROZEN_MPY_DIRS", ""):
192+
if file in settings["FROZEN_MPY_DIRS"]:
193193
boards_to_build.add(board)
194194
continue
195195

196196
# Check supervisor files
197197
# This is useful for limiting workflow changes to the relevant boards
198198
if file.startswith("supervisor"):
199-
if file in settings.get("SRC_SUPERVISOR", ""):
199+
if file in settings["SRC_SUPERVISOR"]:
200200
boards_to_build.add(board)
201201
continue
202202

0 commit comments

Comments
 (0)