Skip to content

Commit e839be5

Browse files
tannewtdhalbert
andauthored
Apply suggestions from code review
Co-authored-by: Dan Halbert <[email protected]>
1 parent 3f419df commit e839be5

File tree

6 files changed

+8
-6
lines changed

6 files changed

+8
-6
lines changed

ports/renode/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Renode is an emulator targeting microcontroller-class devices. This port is a
44
minimal version of CircuitPython that runs under Renode. Renode is designed to
5-
mimic full microcontrollers but CP uses more registers than what Renode has
5+
mimic full microcontrollers but CP uses more peripherals than what Renode has
66
implemented so far. This port allows us to run on a variety of CPUs without
77
worrying about peripherals.
88

ports/renode/Simple32Khz.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// This file is licensed under the MIT License.
66
// Full license text is available in 'licenses/MIT.txt'.
77
//
8-
// This is modified for CircuitPython to tick at 32khz like a slow external
8+
// This is modified for CircuitPython to tick at 32kHz like a slow external
99
// crystal would.
1010
using System;
1111
using Antmicro.Renode.Core;
@@ -16,11 +16,11 @@
1616

1717
namespace Antmicro.Renode.Peripherals.Timers
1818
{
19-
public class Simple32Khz : IDoubleWordPeripheral, IKnownSize
19+
public class Simple32kHz : IDoubleWordPeripheral, IKnownSize
2020
{
2121
public long Size { get { return 0x4; } }
2222

23-
public Simple32Khz(IMachine machine)
23+
public Simple32kHz(IMachine machine)
2424
{
2525
machine.ClockSource.AddClockEntry(new ClockEntry(1, 32768, OnTick, this, String.Empty));
2626
}

ports/renode/boards/peripherals.repl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ sram: Memory.MappedMemory @ sysbus 0x20000000
1010

1111
uart: UART.PicoSoC_SimpleUART @ sysbus 0x40000000
1212

13-
time: Timers.Simple32Khz @ sysbus 0x40001000
13+
time: Timers.Simple32kHz @ sysbus 0x40001000

ports/renode/common-hal/busio/UART.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ uint32_t common_hal_busio_uart_get_baudrate(busio_uart_obj_t *self) {
7373
}
7474

7575
void common_hal_busio_uart_set_baudrate(busio_uart_obj_t *self, uint32_t baudrate) {
76+
mp_raise_NotImplementedError(NULL);
7677
}
7778

7879
mp_float_t common_hal_busio_uart_get_timeout(busio_uart_obj_t *self) {

ports/renode/common-hal/microcontroller/Processor.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ uint32_t common_hal_mcu_processor_get_frequency(void) {
4444
}
4545

4646
void common_hal_mcu_processor_set_frequency(mcu_processor_obj_t *self, uint32_t frequency) {
47+
mp_raise_NotImplementedError(NULL);
4748
}
4849

4950
void common_hal_mcu_processor_get_uid(uint8_t raw_id[]) {

ports/renode/mphalport.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
extern uint32_t common_hal_mcu_processor_get_frequency(void);
3434

3535
void mp_hal_delay_us(mp_uint_t delay) {
36-
// busy_wait_us_32(delay);
36+
// TODO busy_wait_us_32(delay);
3737
}
3838

3939
void mp_hal_disable_all_interrupts(void) {

0 commit comments

Comments
 (0)