move call to show outside loop

rhooper · rhooper · commit ef2a8906ddd1 · 2019-12-16T15:05:09.000-05:00
diff --git a/shared-bindings/_pixelbuf/PixelBuf.c b/shared-bindings/_pixelbuf/PixelBuf.c
@@ -352,9 +352,9 @@ STATIC mp_obj_t pixelbuf_pixelbuf_fill(mp_obj_t self_in, mp_obj_t value) {
     for (size_t offset = 0; offset < self->bytes; offset+= self->pixel_step) {
         pixelbuf_set_pixel(self->buf + offset, self->two_buffers ? (self->rawbuf + offset) : NULL,
                            self->brightness, value, &self->byteorder, self->byteorder.is_dotstar);
-            if (self->auto_write)
-                call_show(self_in);
     }
+    if (self->auto_write)
+        call_show(self_in);
     return mp_const_none;
 }
 STATIC MP_DEFINE_CONST_FUN_OBJ_2(pixelbuf_pixelbuf_fill_obj, pixelbuf_pixelbuf_fill);

Original file line number	Diff line number	Diff line change
`@@ -352,9 +352,9 @@ STATIC mp_obj_t pixelbuf_pixelbuf_fill(mp_obj_t self_in, mp_obj_t value) {`
`352`	`352`	`for (size_t offset = 0; offset < self->bytes; offset+= self->pixel_step) {`
`353`	`353`	`pixelbuf_set_pixel(self->buf + offset, self->two_buffers ? (self->rawbuf + offset) : NULL,`
`354`	`354`	`self->brightness, value, &self->byteorder, self->byteorder.is_dotstar);`
`355`		`- if (self->auto_write)`
`356`		`- call_show(self_in);`
`357`	`355`	`}`
	`356`	`+ if (self->auto_write)`
	`357`	`+ call_show(self_in);`
`358`	`358`	`return mp_const_none;`
`359`	`359`	`}`
`360`	`360`	`STATIC MP_DEFINE_CONST_FUN_OBJ_2(pixelbuf_pixelbuf_fill_obj, pixelbuf_pixelbuf_fill);`