Skip to content

Commit fa3e265

Browse files
authored
Merge pull request #6753 from tannewt/esp_led_reset
Audit all boards with LED pins defined
2 parents 5c184fa + df1435a commit fa3e265

File tree

39 files changed

+96
-77
lines changed

39 files changed

+96
-77
lines changed

ports/espressif/boards/adafruit_esp32s2_camera/mpconfigboard.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
#define MICROPY_HW_NEOPIXEL (&pin_GPIO21)
3333
#define MICROPY_HW_NEOPIXEL_COUNT (6)
3434

35+
#define MICROPY_HW_LED_STATUS (&pin_GPIO2)
36+
3537
#define DEFAULT_I2C_BUS_SDA (&pin_GPIO33)
3638
#define DEFAULT_I2C_BUS_SCL (&pin_GPIO34)
3739

ports/espressif/boards/adafruit_feather_esp32_v2/board.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,5 @@ void board_deinit(void) {
4949
}
5050

5151
bool espressif_board_reset_pin_number(gpio_num_t pin_number) {
52-
// Pull LED down on reset rather than the default up
53-
if (pin_number == 13) {
54-
gpio_config_t cfg = {
55-
.pin_bit_mask = BIT64(pin_number),
56-
.mode = GPIO_MODE_DISABLE,
57-
.pull_up_en = false,
58-
.pull_down_en = true,
59-
.intr_type = GPIO_INTR_DISABLE,
60-
};
61-
gpio_config(&cfg);
62-
return true;
63-
}
6452
return false;
6553
}

ports/espressif/boards/adafruit_feather_esp32_v2/mpconfigboard.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
#define MICROPY_HW_NEOPIXEL (&pin_GPIO0)
3333
#define CIRCUITPY_STATUS_LED_POWER (&pin_GPIO2)
3434

35+
#define MICROPY_HW_LED_STATUS (&pin_GPIO13)
36+
3537
#define CIRCUITPY_BOARD_I2C (1)
3638
#define CIRCUITPY_BOARD_I2C_PIN {{.scl = &pin_GPIO20, .sda = &pin_GPIO22}}
3739

ports/espressif/boards/adafruit_feather_esp32s2/mpconfigboard.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
#define MICROPY_HW_NEOPIXEL (&pin_GPIO33)
3333
#define CIRCUITPY_STATUS_LED_POWER (&pin_GPIO21)
3434

35+
#define MICROPY_HW_LED_STATUS (&pin_GPIO13)
36+
3537
#define DEFAULT_I2C_BUS_SCL (&pin_GPIO4)
3638
#define DEFAULT_I2C_BUS_SDA (&pin_GPIO3)
3739

ports/espressif/boards/adafruit_feather_esp32s2_tft/board.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -141,18 +141,6 @@ bool espressif_board_reset_pin_number(gpio_num_t pin_number) {
141141
gpio_set_level(21, true);
142142
return true;
143143
}
144-
// Pull LED down on reset rather than the default up
145-
if (pin_number == 13) {
146-
gpio_config_t cfg = {
147-
.pin_bit_mask = BIT64(pin_number),
148-
.mode = GPIO_MODE_DISABLE,
149-
.pull_up_en = false,
150-
.pull_down_en = true,
151-
.intr_type = GPIO_INTR_DISABLE,
152-
};
153-
gpio_config(&cfg);
154-
return true;
155-
}
156144
return false;
157145
}
158146

ports/espressif/boards/adafruit_feather_esp32s2_tft/mpconfigboard.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
#define MICROPY_HW_NEOPIXEL (&pin_GPIO33)
3333
#define CIRCUITPY_STATUS_LED_POWER (&pin_GPIO34)
3434

35+
#define MICROPY_HW_LED_STATUS (&pin_GPIO13)
36+
3537
#define DEFAULT_I2C_BUS_SCL (&pin_GPIO41)
3638
#define DEFAULT_I2C_BUS_SDA (&pin_GPIO42)
3739

ports/espressif/boards/adafruit_feather_esp32s2_tftback_nopsram/mpconfigboard.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
#define MICROPY_HW_NEOPIXEL (&pin_GPIO33)
3333
#define CIRCUITPY_STATUS_LED_POWER (&pin_GPIO21)
3434

35+
#define MICROPY_HW_LED_STATUS (&pin_GPIO13)
36+
3537
#define DEFAULT_I2C_BUS_SCL (&pin_GPIO4)
3638
#define DEFAULT_I2C_BUS_SDA (&pin_GPIO3)
3739

ports/espressif/boards/adafruit_feather_esp32s3_4mbflash_2mbpsram/mpconfigboard.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
#define MICROPY_HW_NEOPIXEL (&pin_GPIO33)
3333
#define CIRCUITPY_STATUS_LED_POWER (&pin_GPIO21)
3434

35+
#define MICROPY_HW_LED_STATUS (&pin_GPIO13)
36+
3537
#define DEFAULT_I2C_BUS_SCL (&pin_GPIO4)
3638
#define DEFAULT_I2C_BUS_SDA (&pin_GPIO3)
3739

ports/espressif/boards/adafruit_feather_esp32s3_nopsram/mpconfigboard.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
#define MICROPY_HW_NEOPIXEL (&pin_GPIO33)
3333
#define CIRCUITPY_STATUS_LED_POWER (&pin_GPIO21)
3434

35+
#define MICROPY_HW_LED_STATUS (&pin_GPIO13)
36+
3537
#define DEFAULT_I2C_BUS_SCL (&pin_GPIO4)
3638
#define DEFAULT_I2C_BUS_SDA (&pin_GPIO3)
3739

ports/espressif/boards/adafruit_feather_esp32s3_tft/mpconfigboard.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
#define MICROPY_HW_NEOPIXEL (&pin_GPIO33)
3333
#define CIRCUITPY_STATUS_LED_POWER (&pin_GPIO34)
3434

35+
#define MICROPY_HW_LED_STATUS (&pin_GPIO13)
36+
3537
#define DEFAULT_I2C_BUS_SCL (&pin_GPIO41)
3638
#define DEFAULT_I2C_BUS_SDA (&pin_GPIO42)
3739

0 commit comments

Comments
 (0)