Skip to content

Commit fb15c7c

Browse files
committed
Fix timings table & remove redundant comment
1 parent 9e0993a commit fb15c7c

File tree

1 file changed

+2
-10
lines changed
  • ports/espressif/boards/makerfabs_tft7

1 file changed

+2
-10
lines changed

ports/espressif/boards/makerfabs_tft7/pins.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,8 @@ STATIC const mp_rom_map_elem_t tft_table[] = {
4949
};
5050
MP_DEFINE_CONST_DICT(tft_dict, tft_table);
5151

52-
#if 0
53-
Arduino_RPi_DPI_RGBPanel *gfx = new Arduino_RPi_DPI_RGBPanel(
54-
bus,
55-
800 /* width */, 0 /* hsync_polarity */, 210 /* hsync_front_porch */, 30 /* hsync_pulse_width */, 16 /* hsync_back_porch */,
56-
480 /* height */, 0 /* vsync_polarity */, 22 /* vsync_front_porch */, 13 /* vsync_pulse_width */, 10 /* vsync_back_porch */,
57-
1 /* pclk_active_neg */, 16000000 /* prefer_speed */, true /* auto_flush */);
58-
#endif
59-
6052
STATIC const mp_rom_map_elem_t timings800_table[] = {
61-
{ MP_ROM_QSTR(MP_QSTR_frequency), MP_ROM_INT(16000000) },
53+
{ MP_ROM_QSTR(MP_QSTR_frequency), MP_ROM_INT(6500000) }, // nominal 16MHz, but display is unstable/tears at that frequency
6254
{ MP_ROM_QSTR(MP_QSTR_width), MP_ROM_INT(800) },
6355
{ MP_ROM_QSTR(MP_QSTR_height), MP_ROM_INT(480) },
6456
{ MP_ROM_QSTR(MP_QSTR_hsync_pulse_width), MP_ROM_INT(30) },
@@ -69,7 +61,7 @@ STATIC const mp_rom_map_elem_t timings800_table[] = {
6961
{ MP_ROM_QSTR(MP_QSTR_vsync_front_porch), MP_ROM_INT(22) },
7062
{ MP_ROM_QSTR(MP_QSTR_vsync_back_porch), MP_ROM_INT(10) },
7163
{ MP_ROM_QSTR(MP_QSTR_vsync_idle_low), MP_ROM_FALSE },
72-
{ MP_ROM_QSTR(MP_QSTR_de_active_high), MP_ROM_FALSE },
64+
{ MP_ROM_QSTR(MP_QSTR_de_idle_high), MP_ROM_FALSE },
7365
{ MP_ROM_QSTR(MP_QSTR_pclk_active_high), MP_ROM_FALSE },
7466
{ MP_ROM_QSTR(MP_QSTR_pclk_idle_high), MP_ROM_FALSE },
7567
};

0 commit comments

Comments
 (0)