Skip to content

Commit fefb461

Browse files
committed
use larger partition for ESP32-S2
1 parent ac0a553 commit fefb461

File tree

2 files changed

+4
-13
lines changed

2 files changed

+4
-13
lines changed

ports/espressif/Makefile

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -571,18 +571,14 @@ TARGET_SDKCONFIG = esp-idf-config/sdkconfig-$(IDF_TARGET).defaults
571571
UF2_BOOTLOADER ?= $(CIRCUITPY_USB_DEVICE)
572572

573573
ifeq ($(CIRCUITPY_ESP_FLASH_SIZE), 2MB)
574-
####### No 2MB UF2 boards, so always no OTA, not UF2
574+
# ..... No 2MB UF2 boards, so always no OTA, not UF2
575575
FLASH_SIZE_SDKCONFIG ?= esp-idf-config/sdkconfig-flash-$(CIRCUITPY_ESP_FLASH_SIZE)-no-ota-no-uf2.defaults
576576
else ifeq ($(CIRCUITPY_ESP_FLASH_SIZE), 4MB)
577577
ifeq ($(UF2_BOOTLOADER), 1)
578-
############### TODO: For right now, use no-ota only for ESP32-S3. Eventually it will be for ESP32-S2 as well.
579-
ifeq ($(IDF_TARGET),esp32s3)
580-
FLASH_SIZE_SDKCONFIG ?= esp-idf-config/sdkconfig-flash-$(CIRCUITPY_ESP_FLASH_SIZE)-no-ota.defaults
581-
else
582-
FLASH_SIZE_SDKCONFIG ?= esp-idf-config/sdkconfig-flash-$(CIRCUITPY_ESP_FLASH_SIZE).defaults
583-
endif
578+
#............. ESP32-S2 and ESP32-S3 do not have an extra ota partition for OTA update.
579+
FLASH_SIZE_SDKCONFIG ?= esp-idf-config/sdkconfig-flash-$(CIRCUITPY_ESP_FLASH_SIZE)-no-ota.defaults
584580
else
585-
############### Non-UF2 4MB: C3, C6, etc.
581+
# ............. Non-UF2 4MB: C3, C6, etc.
586582
ifeq ($(CIRCUITPY_4MB_FLASH_LARGE_USER_FS_LAYOUT), 1)
587583
###################### Some boards use a 2MB firmware and almost 2MB user filesystem, for historical reasons.
588584
FLASH_SIZE_SDKCONFIG ?= esp-idf-config/sdkconfig-flash-$(CIRCUITPY_ESP_FLASH_SIZE)-no-ota-no-uf2-large-user_fs.defaults

ports/espressif/mpconfigport.mk

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -262,11 +262,6 @@ CIRCUITPY_SDIOIO = 0
262262

263263
CIRCUITPY_ESP_USB_SERIAL_JTAG ?= 0
264264

265-
# TODO: remove this after ESP32-S2 4MB boards get combined OTA partition.
266-
ifeq ($(CIRCUITPY_ESP_FLASH_SIZE),4MB)
267-
CIRCUITPY__EVE = 0
268-
endif
269-
270265
else ifeq ($(IDF_TARGET),esp32s3)
271266
# Modules
272267
CIRCUITPY_ALARM_TOUCH = 1

0 commit comments

Comments
 (0)