Skip to content

Add basic VT100 scrolling #10108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tannewt merged 8 commits into from
Mar 4, 2025
Merged

Add basic VT100 scrolling #10108

tannewt merged 8 commits into from
Mar 4, 2025

Conversation

@RetiredWizard
Copy link

@RetiredWizard RetiredWizard commented Mar 1, 2025

This PR adds

  • Basic VT100 scrolling (full screen only, I'm looking at scrolling range but it's fighting me)
  • A place holder for the VT100 cursor On/Off sequence
    (thinking may be useful after Addding support for inverted tiles in TileGrid #10102)
  • Support for a third parameter passed to the screen attribute
    (allows for somewhat common reset/foreground/background sequence)
  • Add ESC[H which does the same thing as ESC[0;0H

@RetiredWizard
Copy link
Author

RetiredWizard commented Mar 1, 2025

I have changes ready that add a CIRCUITPY_TERMINALIO_VT100 compile flag to disable the new VT100 escape sequence support on all SAMD21 boards using the mpconfigport.mk file. I figured I should wait to submit the commit so that these failures could be checked out....

@TheKitty
Copy link

TheKitty commented Mar 1, 2025

It looks like flash is overflowing in some languages for some boards. Maybe the code size is making terminalio just big enough to exceed the flash in certain situations for certain languages. @dhalbert might be able to verify.

@RetiredWizard
Copy link
Author

RetiredWizard commented Mar 3, 2025

I've added the logic to disable the advanced VT100 escape sequence for samd21 boards but haven't utilized it yet so that the overflowing boards could be examined in case there is a better approach to resolve the overflows for the particular boards.

tannewt
tannewt requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do disable this on small boards. No need to add new features to them.

tannewt
tannewt approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit bc36b94 into adafruit:main Mar 4, 2025
534 checks passed
@RetiredWizard RetiredWizard deleted the vtscroll branch March 4, 2025 18:44
@RetiredWizard RetiredWizard mentioned this pull request Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RetiredWizard @TheKitty @tannewt