-1 in uint8_t caused ESC[H to clear to line end #10112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I did catch this and one of the later PR commits replaced the uint_8t with an int_16t just in case we ever work with really big screens 😁 EDIT: The change was actually in the next PR #10110 |
|
The -1 flag functionality was actually replaced by the calculation of n_args though so I do like defaulting all the elements to zero. I'll do that in the ranged scroll PR. |
Author
|
Closing in favor of #10110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jokes aside, This causes ESC[H to clear but only go back up to the end of the first line.
Tested. I'll be doing more ansi work now that the nice infra for ANSI is merged in.
I'm pushing this as an individual fix as it breaks displayio terminal applications.