adding feather rp2350 adalogger #10254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'm making some minor edits. Don't merge yet. |
dhalbert
requested changes
Apr 15, 2025
Co-authored-by: Dan Halbert <[email protected]>
dhalbert
reviewed
Apr 15, 2025
ports/raspberrypi/boards/adafruit_feather_rp2350_adalogger/pins.c
Outdated
Show resolved
Hide resolved
dhalbert
requested changes
Apr 15, 2025
ports/raspberrypi/boards/adafruit_feather_rp2350_adalogger/pins.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan Halbert <[email protected]>
Co-authored-by: Dan Halbert <[email protected]>
dhalbert
previously requested changes
Apr 15, 2025
ports/raspberrypi/boards/adafruit_feather_rp2350_adalogger/pins.c
Outdated
Show resolved
Hide resolved
tannewt
approved these changes
May 1, 2025
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
I think this is ready. If not, we can follow up with fixes.
Member
|
this is fine ill test as-is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Feather RP2350 Adalogger board def