Skip to content

Add a delay to KeyMatrix scan. #9665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Add a delay to KeyMatrix scan. #9665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
447cd1e
Add a delay to KeyMatrix scan.
SeanCline Sep 26, 2024
dc52fe3
Update KeyMatrix.c: remove trailing spaces
dhalbert Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions shared-module/keypad/KeyMatrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <string.h>

#include "py/gc.h"
#include "py/mphal.h"
#include "py/runtime.h"
#include "shared-bindings/digitalio/DigitalInOut.h"
#include "shared-bindings/keypad/EventQueue.h"
Expand Down Expand Up @@ -133,6 +134,10 @@ static void keymatrix_scan_now(void *self_in, mp_obj_t timestamp) {
// to switch values. Just switching to an input with a (relatively weak) pullup/pulldown
// causes a slight delay in the output changing, which can cause false readings.
common_hal_digitalio_digitalinout_set_value(row_dio, self->columns_to_anodes);

// Wait a moment to let the columns settle.
mp_hal_delay_us(1);

// Switch the row back to an input, pulled appropriately
common_hal_digitalio_digitalinout_switch_to_input(
row_dio, self->columns_to_anodes ? PULL_UP : PULL_DOWN);
Expand Down