Skip to content

Conversation

@jepler
Copy link

@jepler jepler commented Jan 10, 2025

the configuration that tried to use setuptools_scm was broken. Instead, provides circuitpython-stubs' setup.py with the version determined by setuptools_scm running in the git source directory.

This gets rid of the following message seen during the doc build in github actions:

WARNING setuptools_scm.pyproject_reading toml section missing 'pyproject.toml does not contain a tool.setuptools_scm section'
Traceback (most recent call last):
  File "/tmp/build-env-dsk5kdxt/lib/python3.12/site-packages/setuptools_scm/_integration/pyproject_reading.py", line 36, in read_pyproject
    section = defn.get("tool", {})[tool_name]
              ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
KeyError: 'setuptools_scm'

Compared to the version originally in #9947 this adds fetching tags during the doc build.

Remember to also check if this worked on RTD!

the configuration that tried to use setuptools_scm was broken.
Instead, provides circuitpython-stubs' setup.py with the version
determined by setuptools_scm running in the git source directory.
@jepler jepler requested a review from dhalbert January 11, 2025 19:01
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring out that mysterious error!

@dhalbert dhalbert merged commit 338c1aa into adafruit:main Jan 11, 2025
587 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants