Drop support for MySQL 5.7 and MariaDB 10.3 (#987)

Author: adamchainz

.github/workflows/main.yml

@@ -25,9 +25,7 @@ jobs:
         - '3.10'
         - '3.11'
         database:
-        - mysql:5.7
         - mysql:8.0
-        - mariadb:10.3
         - mariadb:10.4
         - mariadb:10.5
         - mariadb:10.6

HISTORY.rst

@@ -2,6 +2,10 @@
 History
 =======
 
+* Drop support for MySQL 5.7 and MariaDB 10.3.
+  They will both reach EOL this year, and Django 4.2 does not support them.
+  (No actual functionality has been removed, just testing of these versions.)
+
 4.8.0 (2022-12-06)
 ------------------
 

docs/installation.rst

@@ -8,9 +8,9 @@ Python 3.7 to 3.11 supported.
 
 Django 3.2 to 4.1 supported.
 
-MySQL 5.7 to 8.0 supported.
+MySQL 8.0 supported.
 
-MariaDB 10.3 to 10.8 supported.
+MariaDB 10.4 to 10.8 supported.
 
 mysqclient 1.3 to 1.4 supported.
 

docs/queryset_extensions.rst

@@ -251,8 +251,8 @@ Once you’ve done this, the following methods will work.
 
     .. warning::
 
-        The query cache is disabled by default in MySQL 5.7.20+ and MariaDB
-        10.1.7+, and removed in MySQL 8.0+.
+        The query cache was removed in MySQL 8.0, and is disabled by default
+        from MariaDB 10.1.7.
 
     Example usage:
 
@@ -262,7 +262,6 @@ Once you’ve done this, the following methods will work.
         recent_posts = BlogPost.objects.sql_cache().order_by("-created")[:5]
 
     Docs:
-    `MySQL <https://dev.mysql.com/doc/refman/en/select.html>`__ /
     `MariaDB
     <https://mariadb.com/kb/en/mariadb/select/#sql_cache-sql_no_cache>`__.
 
@@ -276,8 +275,8 @@ Once you’ve done this, the following methods will work.
 
     .. warning::
 
-        The query cache is disabled by default in MySQL 5.7.20+ and MariaDB
-        10.1.7+, and removed in MySQL 8.0+.
+        The query cache was removed in MySQL 8.0, and is disabled by default
+        from MariaDB 10.1.7.
 
     Example usage:
 
@@ -290,7 +289,6 @@ Once you’ve done this, the following methods will work.
         )
 
     Docs:
-    `MySQL <https://dev.mysql.com/doc/refman/en/select.html>`__ /
     `MariaDB
     <https://mariadb.com/kb/en/mariadb/select/#sql_cache-sql_no_cache>`__.
 

tests/db_backend/base.py

@@ -5,7 +5,7 @@
 
 class DatabaseWrapper(BaseDatabaseWrapper):
     def init_connection_state(self):
-        if not self.mysql_is_mariadb and self.mysql_version >= (8,):
+        if not self.mysql_is_mariadb:
             sql_mode = ",".join(
                 [
                     "ERROR_FOR_DIVISION_BY_ZERO",

tests/testapp/test_models.py

@@ -31,7 +31,7 @@
 from tests.testapp.models import NameAuthorExtra
 from tests.testapp.models import VanillaAuthor
 from tests.testapp.utils import CaptureLastQuery
-from tests.testapp.utils import skip_if_mysql_8_plus
+from tests.testapp.utils import skip_if_mysql
 from tests.testapp.utils import used_indexes
 
 
@@ -180,13 +180,13 @@ def test_disabled_setting_errors_on_usage(self):
 
         assert "DJANGO_MYSQL_REWRITE_QUERIES" in str(excinfo.value)
 
-    @skip_if_mysql_8_plus()
+    @skip_if_mysql()
     def test_sql_cache(self):
         with CaptureLastQuery() as cap:
             list(Author.objects.sql_cache().all())
         assert cap.query.startswith("SELECT SQL_CACHE ")
 
-    @skip_if_mysql_8_plus()
+    @skip_if_mysql()
     def test_sql_no_cache(self):
         with CaptureLastQuery() as cap:
             list(Author.objects.sql_no_cache().all())

tests/testapp/utils.py

@@ -26,11 +26,9 @@ def conn_is_mysql(connection: BaseDatabaseWrapper) -> TypeGuard[MySQLDatabaseWra
 
 
 @contextmanager
-def skip_if_mysql_8_plus() -> Generator[None, None, None]:
-    if not conn_is_mysql(connection) or (
-        not connection.mysql_is_mariadb and connection.mysql_version >= (8,)
-    ):
-        pytest.skip("Requires MySQL<8 or MariaDB")
+def skip_if_mysql() -> Generator[None, None, None]:
+    if not connection.mysql_is_mariadb:
+        pytest.skip("Requires MariaDB")
     yield