Skip to content

Commit d2e6b3e

Browse files
committed
limit signature
1 parent 36c177f commit d2e6b3e

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

src/django_mysql/models/fields/dynamic.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -323,12 +323,8 @@ def __init__(
323323
data_type: str,
324324
*expressions: Any,
325325
subspec: SpecDict | None = None,
326-
output_field: Field[Any, Any] | None = None,
327-
**extra: Any,
328326
) -> None:
329-
if output_field is not None:
330-
raise ValueError("Cannot set output_field for KeyTransform")
331-
327+
output_field: Field[Any, Any]
332328
if data_type == "BINARY":
333329
output_field = DynamicField(spec=subspec)
334330
else:
@@ -337,7 +333,7 @@ def __init__(
337333
except KeyError:
338334
raise ValueError(f"Invalid data_type {data_type!r}")
339335

340-
super().__init__(*expressions, output_field=output_field, **extra)
336+
super().__init__(*expressions, output_field=output_field)
341337

342338
self.key_name = key_name
343339
self.data_type = data_type

tests/testapp/test_dynamicfield.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -160,12 +160,6 @@ def test_non_existent_transform(self):
160160
def test_has_key(self):
161161
assert list(DynamicModel.objects.filter(attrs__has_key="c")) == self.objs[1:3]
162162

163-
def test_key_transform_initialize_output_field(self):
164-
with pytest.raises(ValueError) as excinfo:
165-
KeyTransform("x", "y", output_field=CharField())
166-
167-
assert str(excinfo.value) == "Cannot set output_field for KeyTransform"
168-
169163
def test_key_transform_initialize_bad_type(self):
170164
with pytest.raises(ValueError) as excinfo:
171165
KeyTransform("x", "unknown")

0 commit comments

Comments
 (0)