Enchance the Wait-SeElementExists/Start-SeChrome

I'm new to Source control please take it easy on me.

1) I've enchanced the Wait-SeElementExists function by adding the option to wait for elements by TagName/ClassName and I've also also converted the tickes to a timespan for more consistency.

2) I've enchanced the Start-SeChrome function by adding the ability yo set the browser default download path and the option to disable the built in pdf viewer.

Author: the-mentor

Selenium.psm1

@@ -4,10 +4,20 @@ function Start-SeChrome {
     Param(
         [Parameter(Mandatory = $false)]
         [array]$Arguments,
-        [switch]$HideVersionHint
+        [switch]$HideVersionHint,
+        [System.IO.FileInfo]$DefaultDownloadPath,
+        [bool]$DisableBuiltInPDFViewer=$true
     )
+
+    $Chrome_Options = New-Object -TypeName "OpenQA.Selenium.Chrome.ChromeOptions"
+    if($DefaultDownloadPath){
+        Write-Host "Setting Default Download directory: $DefaultDownloadPath"
+        $Chrome_Options.AddUserProfilePreference('download', @{'default_directory' = $($DefaultDownloadPath.FullName); 'prompt_for_download' = $false; })
+    }
+    if($DisableBuiltInPDFViewer){
+       $Chrome_Options.AddUserProfilePreference('plugins', @{'always_open_pdf_externally' =  $true;})
+    }
     if($Arguments) {
-        $Chrome_Options = New-Object -TypeName "OpenQA.Selenium.Chrome.ChromeOptions"
         $Chrome_Options.AddArguments($Arguments)
     }
     if(!$HideVersionHint)
@@ -199,12 +209,14 @@ function Save-SeScreenshot {
         }
 }
 
-function Wait-SeElementExists {
+function Wait-SeElementExists{
     param(
         $Driver,
         $Timeout = 30,
         $Id,
-        $Name
+        $Name,
+        $TagName,
+        $ClassName
     )
     if($Id)
     {
@@ -214,11 +226,20 @@ function Wait-SeElementExists {
     {
         $TargetElement = [OpenQA.Selenium.By]::Name($Name)
     }
+    elseif($TagName)
+    {
+        $TargetElement = [OpenQA.Selenium.By]::TagName($TagName)
+    }
+    elseif($ClassName)
+    {
+        $TargetElement = [OpenQA.Selenium.By]::ClassName($ClassName)
+    }
     else
     {
-        throw "Please specify -Id or -Name"
+        throw "Please specify -Id or -Name or -TagName or -ClassName"
     }
-    $WebDriverWait = New-Object OpenQA.Selenium.Support.UI.WebDriverWait $Driver, ($Timeout * 10000000) # ticks
+
+    $WebDriverWait = New-Object -TypeName OpenQA.Selenium.Support.UI.WebDriverWait($Driver, (New-TimeSpan -Seconds $Timeout))
     $Condition = [OpenQA.Selenium.Support.UI.ExpectedConditions]::ElementExists($TargetElement)
     $WebDriverWait.Until($Condition)
 }