Stop string call method arguments from getting spaces removed.

Author: adamghill

django_unicorn/call_method_parser.py

@@ -81,10 +81,14 @@ def parse_args(args: str) -> List[Any]:
     """
     found_args = []
     arg = ""
+
     curly_bracket_count = 0
     square_bracket_count = 0
     parenthesis_count = 0
 
+    in_single_quote = False
+    in_double_quote = False
+
     def _eval_arg(_arg):
         try:
             _arg = literal_eval(_arg)
@@ -114,7 +118,7 @@ def _parse_arg(_arg):
         return _arg
 
     for c in args:
-        if not c.strip():
+        if not in_single_quote and not in_double_quote and not c.strip():
             continue
 
         if (
@@ -147,6 +151,10 @@ def _parse_arg(_arg):
         elif c == ")":
             parenthesis_count -= 1
             arg = _parse_arg(arg)
+        elif c == "'":
+            in_single_quote = not in_single_quote
+        elif c == '"':
+            in_double_quote = not in_double_quote
 
     if arg:
         arg = _eval_arg(arg)

django_unicorn/views.py

@@ -9,12 +9,7 @@
 
 import orjson
 
-from .call_method_parser import (
-    InvalidKwarg,
-    parse_args,
-    parse_call_method_name,
-    parse_kwarg,
-)
+from .call_method_parser import InvalidKwarg, parse_call_method_name, parse_kwarg
 from .components import UnicornField, UnicornView
 from .errors import UnicornViewError
 from .utils import generate_checksum

example/unicorn/templates/unicorn/text-inputs.html

@@ -37,9 +37,12 @@
     <button unicorn:click="set_name">set_name</button>
     <button unicorn:click="set_name()">set_name()</button>
     <button unicorn:click="set_name('')">set_name('')</button>
-    <button unicorn:click="set_name('blob')">set_name('blob')</button>
+    <button unicorn:click="set_name('blob 2')">set_name('blob 2')</button>
     <button unicorn:click="name='human'">name='human'</button>
 
     <br />
     Hello {{ name|title }} 👋
+
+    <br />
+    <button unicorn:click='set_name($event.target.value.trim())' value=' button value '>set_name($event.target.value.trim())</button>
 </div>

tests/call_method_parser/test_parse_args.py

@@ -20,6 +20,22 @@ def test_single_quote_str_arg():
     assert isinstance(actual[0], str)
 
 
+def test_str_with_space_arg():
+    expected = ["django unicorn"]
+    actual = parse_args("'django unicorn'")
+
+    assert actual == expected
+    assert isinstance(actual[0], str)
+
+
+def test_complicated_str_with_space_arg():
+    expected = ["django's \"  '  unicorn"]
+    actual = parse_args("django's \"  '  unicorn")
+
+    assert actual == expected
+    assert isinstance(actual[0], str)
+
+
 def test_double_quote_str_arg():
     expected = ["1"]
     actual = parse_args('"1"')