Add hasValue to utils.

Author: adamghill

django_unicorn/static/js/element.js

@@ -1,5 +1,5 @@
 import { Attribute } from "./attribute.js";
-import { isEmpty } from "./utils.js";
+import { isEmpty, hasValue } from "./utils.js";
 
 /**
  * Encapsulate DOM element for Unicorn-related information.
@@ -166,11 +166,7 @@ export class Element {
    * A key that takes into consideration the db name and pk.
    */
   dbKey() {
-    if (
-      !isEmpty(this.db) &&
-      typeof this.db.pk !== "undefined" &&
-      typeof this.db.name !== "undefined"
-    ) {
+    if (hasValue(this.db) && hasValue(this.db.pk) && hasValue(this.db.name)) {
       return `${this.db.name}:${this.db.pk}`;
     }
 
@@ -203,7 +199,7 @@ export class Element {
    * Sets the value of an element. Tries to deal with HTML weirdnesses.
    */
   setValue(val) {
-    if (typeof this.el.type === "undefined") {
+    if (isEmpty(this.el.type)) {
       return;
     }
 

django_unicorn/static/js/unicorn.js

@@ -1,4 +1,5 @@
 import { Component } from "./component.js";
+import { hasValue } from "./utils.js";
 
 let messageUrl = "";
 const csrfTokenHeaderName = "X-CSRFToken";
@@ -33,7 +34,7 @@ export function call(componentName, methodName) {
   let component;
 
   Object.keys(components).forEach((id) => {
-    if (typeof component === "undefined") {
+    if (hasValue(component)) {
       const _component = components[id];
 
       if (_component.name === componentName) {

django_unicorn/static/js/utils.js

@@ -1,5 +1,5 @@
 /**
- * Checks if an object is empty. Useful for check if a dictionary has any values.
+ * Checks if an object is empty. Useful to check if a dictionary has a value.
  */
 export function isEmpty(obj) {
   return (
@@ -9,6 +9,13 @@ export function isEmpty(obj) {
   );
 }
 
+/**
+ * Checks if an object has a value.
+ */
+export function hasValue(obj) {
+  return !isEmpty(obj);
+}
+
 /**
  * Checks if a string has the search text.
  */