Skip to content

Commit a65e157

Browse files
committed
Log un-pickleable error as warning.
1 parent acd97f6 commit a65e157

File tree

2 files changed

+14
-7
lines changed

2 files changed

+14
-7
lines changed

django_unicorn/components/unicorn_view.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -740,7 +740,7 @@ def _get_component_class(
740740
try:
741741
cacheable_component = get_cacheable_component(component)
742742
except UnicornCacheError as e:
743-
logger.exception(e)
743+
logger.warning(e)
744744

745745
if cacheable_component:
746746
if COMPONENTS_MODULE_CACHE_ENABLED:

django_unicorn/views.py

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from .call_method_parser import InvalidKwarg, parse_call_method_name, parse_kwarg
1818
from .components import UnicornField, UnicornView
1919
from .decorators import timed
20-
from .errors import UnicornViewError
20+
from .errors import UnicornCacheError, UnicornViewError
2121
from .message import ComponentRequest, Return
2222
from .serializer import dumps, loads
2323
from .settings import get_cache_alias, get_serial_enabled, get_serial_timeout
@@ -509,7 +509,11 @@ def _process_component_request(
509509
component.rendered(rendered_component)
510510

511511
cache = caches[get_cache_alias()]
512-
cache.set(component.component_cache_key, get_cacheable_component(component))
512+
513+
try:
514+
cache.set(component.component_cache_key, get_cacheable_component(component))
515+
except UnicornCacheError as e:
516+
logger.warning(e)
513517

514518
partial_doms = []
515519

@@ -600,10 +604,13 @@ def _process_component_request(
600604
parent_dom = parent_component.render()
601605
component.parent_rendered(parent_dom)
602606

603-
cache.set(
604-
parent_component.component_cache_key,
605-
get_cacheable_component(parent_component),
606-
)
607+
try:
608+
cache.set(
609+
parent_component.component_cache_key,
610+
get_cacheable_component(parent_component),
611+
)
612+
except UnicornCacheError as e:
613+
logger.warning(e)
607614

608615
parent.update(
609616
{

0 commit comments

Comments
 (0)