Open
Conversation
nerdoc
reviewed
Mar 6, 2022
| {% extends "www/base.html" %} | ||
| {% load crispy_forms_tags unicorn %} | ||
|
|
||
| {% load crispy_forms_tags %} |
Contributor
There was a problem hiding this comment.
this is unnecessarily loaded twice
nerdoc
reviewed
Mar 6, 2022
| <div unicorn:view> | ||
| <h2>Crispy</h2> | ||
|
|
||
| {% crispy view.form_class view.form_class.helper %} |
Contributor
There was a problem hiding this comment.
the view.form_class.helper can be omitted (if FormHelper attr is called helper, as you did)
nerdoc
reviewed
Mar 10, 2022
| super().__init__(*args, **kwargs) | ||
| self.helper = FormHelper() | ||
| self.helper.form_id = "id-exampleForm" | ||
| self.helper.form_class = "blueForms" |
Contributor
There was a problem hiding this comment.
you can remove this line from the unicorn crispy example as well - this is just a CSS that is added, from the crispy example.
nerdoc
suggested changes
Mar 10, 2022
Contributor
nerdoc
left a comment
nerdoc
left a comment
There was a problem hiding this comment.
This may work for a DirectView. But if you build a "normal" component which you include using {% unicorn ... %}, it doesn't find the form_classvariable in the context... This is a major showstopper...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example with crispy forms for #368 and #362.