Don't use reflection in tests

Author: adamhathcock

src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs

@@ -212,13 +212,32 @@ protected override IReader CreateReaderForSolidExtraction() =>
     public override long TotalSize =>
         _database?._packSizes.Aggregate(0L, (total, packSize) => total + packSize) ?? 0;
 
-    private sealed class SevenZipReader : AbstractReader<SevenZipEntry, SevenZipVolume>
+    internal sealed class SevenZipReader : AbstractReader<SevenZipEntry, SevenZipVolume>
     {
         private readonly SevenZipArchive _archive;
         private SevenZipEntry? _currentEntry;
         private Stream? _currentFolderStream;
         private CFolder? _currentFolder;
 
+        /// <summary>
+        /// Enables internal diagnostics for tests.
+        /// When disabled (default), diagnostics properties return null to avoid exposing internal state.
+        /// </summary>
+        internal bool DiagnosticsEnabled { get; set; }
+
+        /// <summary>
+        /// Current folder instance used to decide whether the solid folder stream should be reused.
+        /// Only available when <see cref="DiagnosticsEnabled"/> is true.
+        /// </summary>
+        internal object? DiagnosticsCurrentFolder => DiagnosticsEnabled ? _currentFolder : null;
+
+        /// <summary>
+        /// Current shared folder stream instance.
+        /// Only available when <see cref="DiagnosticsEnabled"/> is true.
+        /// </summary>
+        internal Stream? DiagnosticsCurrentFolderStream =>
+            DiagnosticsEnabled ? _currentFolderStream : null;
+
         internal SevenZipReader(ReaderOptions readerOptions, SevenZipArchive archive)
             : base(readerOptions, ArchiveType.SevenZip) => this._archive = archive;
 

tests/SharpCompress.Test/SevenZip/SevenZipArchiveTests.cs

@@ -1,7 +1,6 @@
 using System;
 using System.IO;
 using System.Linq;
-using System.Reflection;
 using SharpCompress.Archives;
 using SharpCompress.Archives.SevenZip;
 using SharpCompress.Common;
@@ -288,19 +287,8 @@ public void SevenZipArchive_Solid_VerifyStreamReuse()
 
         using var reader = archive.ExtractAllEntries();
 
-        // Use reflection to access the private fields
-        var readerType = reader.GetType();
-        var folderStreamField = readerType.GetField(
-            "_currentFolderStream",
-            BindingFlags.NonPublic | BindingFlags.Instance
-        );
-        var currentFolderField = readerType.GetField(
-            "_currentFolder",
-            BindingFlags.NonPublic | BindingFlags.Instance
-        );
-
-        Assert.NotNull(folderStreamField);
-        Assert.NotNull(currentFolderField);
+        var sevenZipReader = Assert.IsType<SevenZipArchive.SevenZipReader>(reader);
+        sevenZipReader.DiagnosticsEnabled = true;
 
         Stream? currentFolderStreamInstance = null;
         object? currentFolder = null;
@@ -322,9 +310,8 @@ public void SevenZipArchive_Solid_VerifyStreamReuse()
 
                 entryCount++;
 
-                // Get the current folder and folder stream via reflection
-                var folderStream = folderStreamField.GetValue(reader) as Stream;
-                var folder = currentFolderField.GetValue(reader);
+                var folderStream = sevenZipReader.DiagnosticsCurrentFolderStream;
+                var folder = sevenZipReader.DiagnosticsCurrentFolder;
 
                 Assert.NotNull(folderStream); // Folder stream should exist
 
@@ -356,9 +343,6 @@ public void SevenZipArchive_Solid_VerifyStreamReuse()
         Assert.True(entryCount > 1, "Test should have multiple entries to verify stream reuse");
 
         // The critical check: within a single folder, the stream should NEVER be recreated
-        Assert.Equal(
-            0,
-            streamRecreationsWithinFolder
-        ); // Folder stream should remain the same for all entries in the same folder
+        Assert.Equal(0, streamRecreationsWithinFolder); // Folder stream should remain the same for all entries in the same folder
     }
 }